Repository navigation
fix: update projectGenerator VS download URL from nightly to latest - #8646
Closed
ConnorQi01 wants to merge 1 commit into
Closed
ConnorQi01 wants to merge 1 commit into
ConnorQi01 wants to merge 1 commit into
Conversation
The projectGenerator CI workflow (build-vs.yml) was updated in openframeworks#691 to use 'latest' as the release tag instead of 'nightly'. However, install.sh still referenced the old 'nightly' tag URL, causing Windows CI setup to fail with exit code 127 when projectGenerator-vs.zip could not be found. Update the URL to use 'latest' to match the current release tag. Fixes: openframeworks/projectGenerator#702
Member
|
Thanks! the issue was caused by GitHub Actions not building the VS action workflow when a .md file was changed. This would have worked, but not needed now. ProjectGenerator -> Merged PR -> Builds to Latest ( clears and releases) download scripts should then always try and download nightly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/ci/vs/install.shdownloadsprojectGenerator-vs.zipusing a hardcodednightlytag URL:URL="https://github.com/openframeworks/projectGenerator/releases/download/nightly/projectGenerator-vs.zip"However, openframeworks/projectGenerator#691 changed the release tag from
nightlytolatestin the projectGenerator CI workflow. As a result,projectGenerator-vs.zipis no longer available under thenightlytag, causing Windows CI setup to fail with exit code 127.Tracked in: openframeworks/projectGenerator#702
Fix
Update the URL to use
latestto match the current release tag in the projectGenerator repository.Testing
This change aligns the download URL with the actual release tag used by projectGenerator's CI.