Repository navigation
Conversation
danoli3
marked this pull request as draft
November 5, 2026 06:07
MSVC jobs were the wall clock (10–14 min) and skipped ccache. Use hendrikmuhs/ccache-action variant sccache, wrap cl.exe for msbuild, and pass the same properties through cmake --build. emptyExample and allAddonsExample share OF sources, so the second project in a job should hit the cache even on a cold runner. Subsequent runs restore the GitHub Actions cache per vsYear/platform/toolset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC CI was the wall clock (10–14 min per cell) and skipped ccache. This wires sccache through
cl.exeforbuild-vsandbuild-cmake (vs-x64).Why sccache
hendrikmuhs/ccache-actionalready installs ccache on Linux/macOS. Its own README recommends sccache on Windows.cl.exedoes not readCC/CXX, so the action alone is not enough.Change
scripts/ci/vs/setup_sccache_cl.ps1writes asccache-cl.cmdwrapper and exports msbuild properties:CLToolExe,CLToolPath,TrackFileAccess=false,UseMultiToolTask=true,DebugInformationFormat=OldStyle(/Z7, which sccache can hash).build-vs: sccache pervsYear/platform/toolset,ilammy/msvc-dev-cmdsocl.exeis on PATH, then the four emptyExample / allAddons Debug+Release msbuilds.build-cmake (vs-x64): same wrapper;scripts/ci/cmake/build.shforwardsCMAKE_VS_MSBUILD_ARGStocmake --build.emptyExample and allAddonsExample compile the same OF core, so allAddons should hit within a job on the first run. Later runs restore the Actions cache.
First CI run on this PR is a cold cache (similar wall clock, plus a short install). After it lands, look for sccache hit rates in the action post step.