Skip to content

[DONE] FIX : Use docker compose with apple silicon chip #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ptitloup
Copy link

add comment in readme to use docker compose with apple silicon

@ptitloup ptitloup self-assigned this Apr 25, 2025
Copy link
Member

@kernicPanel kernicPanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we should not use pseudo tags in PR titles (like [DONE]) instead we should use the draft state.

@@ -32,6 +32,18 @@ The easiest way to start working on the project is to use GNU Make:
$ make bootstrap
```

> Please note that with apple silicon (Mx chips), you may encounter difficulties launching docker compose, notably because some images are not compatible. In this case, you can specify the platform in the docker compose file, as in the example below:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep the line length around 80 chars, please ?
It's easier to read, and keeps consistency around the project.

> - app
>
> dockerize:
> + platform: "linux/amd64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, we should try to use export DOCKER_DEFAULT_PLATFORM=linux/amd64 instead of keeping uncommited edits in docker-compose.yml.

@jonathanreveille
Copy link
Member

jonathanreveille commented Apr 25, 2025

I share the same idea than @kernicPanel, I would just make the title the following way :
📝(docker) instructions to use docker compose with apple silicon chip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants