👔(backend) add properties for batch order model #1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanreveille
force-pushed
the
improve/add_properties_for_batch_order_model
branch
6 times, most recently
from
5d03972 to
b445c3b
Compare
To help developers while working with batch order objects, we have added new properties on the model allowing us to verify quickly if the object is eligible to be or is in a specific state. It avoids us comparing the object to different states. Also, it reflects the business logic of the batch order.
To enhance the developer experience for testing, we have refactor the batch order factory to create the related objects depending on the given state of the object.
jonathanreveille
force-pushed
the
improve/add_properties_for_batch_order_model
branch
from
b445c3b to
243fa18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To help developers while working with batch order objects, we have added new properties on the model allowing us to verify quickly if the object is eligible to be or is in a specific state. It avoids us comparing the object to different states. Also, it reflects the business logic of the batch order.
Proposal
BatchOrderFactoryto create related objects depending the given state