wip #1116
Draft
wip #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use babel get_currency_sybol with DEFAULT_CURRENCY settings in several places. Using a dedicated function simplifies this.
As a discount is always removing value, a negative sign is more explicit.
Adding `discount` to the order serializer allows administrators to view the discount applied to an order. Using `get_default_currency_symbol` ensures consistent formatting across the application.
Adding `total` and `discount` columns allows administrators to view the total price and discount applied to orders directly from the table. Accompanying tests ensure the new columns render correctly.
kernicPanel
force-pushed
the
dev/rename-order_group
branch
from
9258d16 to
755c121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replace order group with offer rule.
Proposal
Description...