🐛(backend) catch ClientError in _get_items to avoid crashing - #2758
Open
jonathanreveille wants to merge 1 commit into
Open
🐛(backend) catch ClientError in _get_items to avoid crashing#2758jonathanreveille wants to merge 1 commit into
ClientError in _get_items to avoid crashing#2758jonathanreveille wants to merge 1 commit into
Conversation
We have portions of code still calling AWS services and we don't use it anymore. Those portion of code still calls boto3 client that hits AWS. The django commands that triggers those portion of code will systematically fail and raise uncaught errors in our sentry. To exit in a proper way, we return an empty list when the credentials are not set.
jonathanreveille
changed the title
ClientError in _get_items to avoid crashingClientError in _get_items to avoid crashing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
We have portions of code still calls in staging AWS services that we don't use it anymore. Those portion of code still calls boto3 client that hits AWS. The django commands that triggers those portion of code will systematically fail and raise uncaught errors in our sentry. To exit in a proper way, we return an empty list when the credentials are not set.
Proposal