fix: re-apply Overture layers after basemap style change#4
Conversation
Switching basemaps calls map.setStyle(), which wipes every non-base source and layer, so the visible Overture themes silently disappeared. Re-add them on the style.load event and bump the version to 0.2.0.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughVersion bumped to 0.2.0 across plugin manifest, package manifest, and exported metadata. OvertureMapsControl now persists visible Overture layers after MapLibre basemap style changes by registering and managing a ChangesVersion Release and Style Persistence
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
style.loadevent so visible themes survive a basemap change (map.setStyle()drops all non-base layers).style.loadhandler in the control's teardown and bump the package/plugin version to 0.2.0.Test plan
npm run test(57 tests pass)Summary by CodeRabbit
Chores
Bug Fixes