Skip to content

whitebox v2.4.2#134

Merged
brownag merged 29 commits intomasterfrom
v242
Oct 12, 2025
Merged

whitebox v2.4.2#134
brownag merged 29 commits intomasterfrom
v242

Conversation

@brownag
Copy link
Copy Markdown
Member

@brownag brownag commented Oct 10, 2025

whitebox 2.4.2

  • wbt_source(): now accepts tmpdir argument which defaults to tempdir() (not getwd() or wbt_wd()) that is used for storing the intermediate shapefiles needed for WhiteboxTools

    • Also, the pattern for temporary file names is now customizable via pattern argument
  • Bug fixes for wbt_source():

    • No longer writes temporary intermediate shapefiles to the working directory when passed a non-shapefile vector data source.

      • The temporary directory is used by default, unless new tmpdir argument is specified. This could be a breaking change if you were relying on the temporary files to be present in the WhiteboxTools working directory. Specify tmpdir in call to wbt_source() to make old behavior explicit.
    • Properly uses layer argument for data sources (e.g. GPKG) that may contain multiple vector layers of interest (thanks to @mps9506 for reporting; wbt_source error on geopackage #132)

@brownag brownag marked this pull request as ready for review October 10, 2025 01:07
Copilot AI review requested due to automatic review settings October 10, 2025 01:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the whitebox R package to version 2.4.2, focusing on improvements to the wbt_source() function for better temporary file handling and bug fixes.

Key changes include:

  • Enhanced wbt_source() function with new tmpdir and pattern arguments for better control over temporary file creation
  • Fixed bug where temporary shapefiles were incorrectly written to the working directory instead of a temporary directory
  • Improved layer handling for multi-layer data sources like GPKG files

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
DESCRIPTION Updated package version to 2.4.2 and added ORCID for maintainer
R/wbt_source.R Added tmpdir and pattern parameters, improved raster handling, and fixed temporary file location logic
man/wbt_source.Rd Updated documentation to reflect new function parameters
man/whitebox-package.Rd Added ORCID information for package maintainer
inst/CITATION Updated version number and year for package citation
NEWS.md Added changelog entry documenting the new features and bug fixes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread inst/CITATION Outdated
Comment thread R/wbt_source.R Outdated
@brownag brownag requested a review from Copilot October 10, 2025 01:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread R/wbt_source.R Outdated
Comment thread R/wbt_source.R Outdated
@brownag brownag requested a review from Copilot October 10, 2025 01:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread R/wbt_source.R Outdated
@brownag brownag requested a review from Copilot October 10, 2025 01:36
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread R/wbt_source.R
Comment thread R/wbt_source.R Outdated
 - fix branching with sf-only dependencies
 - ensure all supported objects pass thru correctly
@brownag brownag requested a review from Copilot October 10, 2025 17:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 8 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread R/wbt_source.R
Comment thread R/wbt_source.R Outdated
Comment thread R/wbt_source.R Outdated
Comment thread R/wbt_source.R Outdated
Comment thread man/wbt_source.Rd Outdated
Comment thread R/wbt_source.R Outdated
Comment thread man/wbt_source.Rd
Comment thread R/wbt_source.R
@brownag brownag requested a review from Copilot October 10, 2025 17:42
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@brownag brownag requested a review from Copilot October 10, 2025 18:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread R/wbt_source.R Outdated
Comment thread man/wbt_source.Rd Outdated
Comment thread R/wbt_source.R
Comment thread R/wbt_source.R
Comment thread R/wbt_source.R Outdated
@brownag brownag requested a review from Copilot October 10, 2025 18:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread R/wbt_source.R Outdated
Comment thread R/wbt_source.R Outdated
Comment thread R/wbt_source.R
Comment thread R/wbt_source.R Outdated
Comment thread R/wbt_source.R Outdated
@brownag brownag requested a review from Copilot October 11, 2025 00:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread R/wbt_source.R Outdated
Comment thread R/wbt_source.R Outdated
Comment thread R/wbt_source.R Outdated
Comment thread man/wbt_source.Rd
Comment thread man/wbt_source.Rd
@brownag brownag requested a review from Copilot October 11, 2025 03:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 19 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/testthat/test-wbt_source.R Outdated
Comment thread tests/testthat/test-wbt_source.R Outdated
Comment thread inst/extdata/STATSGO2.prj
Comment thread R/wbt_source.R Outdated
@brownag brownag requested a review from Copilot October 11, 2025 22:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 19 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread R/wbt_source.R
Comment thread tests/testthat/test-wbt_source.R Outdated
Comment thread tests/testthat/test-wbt_source.R
Comment thread R/wbt_source.R Outdated
@brownag brownag requested a review from Copilot October 11, 2025 22:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 19 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread R/wbt_source.R
@brownag brownag requested a review from Copilot October 11, 2025 23:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 19 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/testthat/test-wbt_source.R
Comment thread tests/testthat/test-wbt_source.R
Comment thread R/wbt_source.R
@brownag brownag merged commit 11ef595 into master Oct 12, 2025
6 checks passed
@brownag brownag deleted the v242 branch October 12, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants