Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the whitebox R package to version 2.4.2, focusing on improvements to the wbt_source() function for better temporary file handling and bug fixes.
Key changes include:
- Enhanced
wbt_source()function with newtmpdirandpatternarguments for better control over temporary file creation - Fixed bug where temporary shapefiles were incorrectly written to the working directory instead of a temporary directory
- Improved layer handling for multi-layer data sources like GPKG files
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| DESCRIPTION | Updated package version to 2.4.2 and added ORCID for maintainer |
| R/wbt_source.R | Added tmpdir and pattern parameters, improved raster handling, and fixed temporary file location logic |
| man/wbt_source.Rd | Updated documentation to reflect new function parameters |
| man/whitebox-package.Rd | Added ORCID information for package maintainer |
| inst/CITATION | Updated version number and year for package citation |
| NEWS.md | Added changelog entry documenting the new features and bug fixes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- fix branching with sf-only dependencies - ensure all supported objects pass thru correctly
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 8 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 19 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 19 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 19 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 19 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
whitebox 2.4.2
wbt_source(): now acceptstmpdirargument which defaults totempdir()(notgetwd()orwbt_wd()) that is used for storing the intermediate shapefiles needed for WhiteboxToolspatternargumentBug fixes for
wbt_source():No longer writes temporary intermediate shapefiles to the working directory when passed a non-shapefile vector data source.
tmpdirargument is specified. This could be a breaking change if you were relying on the temporary files to be present in the WhiteboxTools working directory. Specifytmpdirin call towbt_source()to make old behavior explicit.Properly uses
layerargument for data sources (e.g. GPKG) that may contain multiple vector layers of interest (thanks to @mps9506 for reporting; wbt_source error on geopackage #132)