Skip to content

fix: remove sample DEM data from .Rbuildignore#137

Merged
brownag merged 7 commits intomasterfrom
v243
Oct 19, 2025
Merged

fix: remove sample DEM data from .Rbuildignore#137
brownag merged 7 commits intomasterfrom
v243

Conversation

@brownag
Copy link
Copy Markdown
Member

@brownag brownag commented Oct 18, 2025

Copilot AI review requested due to automatic review settings October 18, 2025 19:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where sample DEM data was being excluded from the R package build by modifying the .Rbuildignore file to allow specific test data files while still excluding other TIFF files.

  • Updated .Rbuildignore pattern to exclude TIFF files except for the specific DEM test data file
  • Added defensive test code to handle cases where sample data files might not exist

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.Rbuildignore Modified regex pattern to allow inst/extdata/DEM.tif while excluding other TIFF files
tests/testthat/test-wbt_source.R Added error handling and file existence checks for sample data

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .Rbuildignore
@brownag brownag requested a review from Copilot October 19, 2025 01:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread R/whitebox-package.R Outdated
Comment thread R/whitebox-package.R Outdated
Comment thread .Rbuildignore
@brownag brownag self-assigned this Oct 19, 2025
@brownag brownag requested a review from Copilot October 19, 2025 01:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .Rbuildignore
Comment thread R/whitebox-package.R
@brownag brownag merged commit e7734b2 into master Oct 19, 2025
6 checks passed
@brownag brownag deleted the v243 branch October 19, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] file asset access issues on CRAN

2 participants