-
Notifications
You must be signed in to change notification settings - Fork 75
Add test data covering different native (geoarrow-based) encodings #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
6ba4fd4
7e9eed2
c1f11eb
5135493
ffb547d
2981b60
6c9390f
3466e1f
9c129d1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| "col","geometry" | ||
| 0,"LINESTRING (30 10, 10 30, 40 40)" | ||
| 1,"LINESTRING EMPTY" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "col","geometry" | ||
| 0,"MULTILINESTRING ((30 10, 10 30, 40 40))" | ||
| 1,"MULTILINESTRING ((10 10, 20 20, 10 40), (40 40, 30 30, 40 20, 30 10))" | ||
| 2,"MULTILINESTRING EMPTY" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "col","geometry" | ||
| 0,"MULTIPOINT ((30 10))" | ||
| 1,"MULTIPOINT ((10 40), (40 30), (20 20), (30 10))" | ||
| 2,"MULTIPOINT EMPTY" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| "col","geometry" | ||
| 0,"MULTIPOLYGON (((30 10, 40 40, 20 40, 10 20, 30 10)))" | ||
| 1,"MULTIPOLYGON (((30 20, 45 40, 10 40, 30 20)), ((15 5, 40 10, 10 20, 5 10, 15 5)))" | ||
| 2,"MULTIPOLYGON (((40 40, 20 45, 45 30, 40 40)), ((20 35, 10 30, 10 10, 30 5, 45 20, 20 35), (30 20, 20 15, 20 25, 30 20)))" | ||
| 3,"MULTIPOLYGON EMPTY" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| "col","geometry" | ||
| 0,"POINT (30 10)" | ||
| 1,"POINT EMPTY" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "col","geometry" | ||
| 0,"POLYGON ((30 10, 40 40, 20 40, 10 20, 30 10))" | ||
| 1,"POLYGON ((35 10, 45 45, 15 40, 10 20, 35 10), (20 30, 35 35, 30 20, 20 30))" | ||
| 2,"POLYGON EMPTY" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,195 @@ | ||
| """ | ||
| Generates example data using pyarrow by running `python generate_test_data.py`. | ||
|
|
||
| You can print the metadata with: | ||
|
|
||
| .. code-block:: python | ||
|
|
||
| >>> import json, pprint, pyarrow.parquet as pq | ||
| >>> pprint.pprint(json.loads(pq.read_schema("example.parquet").metadata[b"geo"])) | ||
| """ | ||
| import json | ||
| import pathlib | ||
| import copy | ||
|
|
||
| import pyarrow as pa | ||
| import pyarrow.parquet as pq | ||
| from pyarrow.csv import write_csv | ||
|
|
||
| from shapely import from_wkt, to_wkb | ||
|
|
||
|
|
||
| HERE = pathlib.Path(__file__).parent | ||
|
|
||
|
|
||
| metadata_template = { | ||
| "version": "1.1.0", | ||
| "primary_column": "geometry", | ||
| "columns": { | ||
| "geometry": { | ||
| "encoding": "WKB", | ||
| "geometry_type": [], | ||
|
jorisvandenbossche marked this conversation as resolved.
Outdated
|
||
| }, | ||
| }, | ||
| } | ||
|
|
||
|
|
||
| ## Various geometry types with WKB and native (GeoArrow-based) encodings | ||
|
|
||
| def write_encoding_files(geometries_wkt, geometries_geoarrow, geometry_type): | ||
|
jorisvandenbossche marked this conversation as resolved.
|
||
|
|
||
| table = pa.table({"col": range(len(geometries_wkt)), "geometry": geometries_wkt}) | ||
| write_csv(table, HERE / f"data-{geometry_type.lower()}.wkt") | ||
|
|
||
| # WKB encoding | ||
| table = pa.table( | ||
| {"col": range(len(geometries_wkt)), "geometry": to_wkb(from_wkt(geometries_wkt))} | ||
| ) | ||
| metadata = copy.deepcopy(metadata_template) | ||
| metadata["columns"]["geometry"]["geometry_type"] = [geometry_type] | ||
|
jorisvandenbossche marked this conversation as resolved.
Outdated
|
||
| table = table.replace_schema_metadata({"geo": json.dumps(metadata)}) | ||
| pq.write_table(table, HERE / f"data-{geometry_type.lower()}-encoding_wkb.parquet") | ||
|
jorisvandenbossche marked this conversation as resolved.
|
||
|
|
||
| # native (geoarrow) encoding | ||
| table = pa.table( | ||
| {"col": range(len(geometries_wkt)), "geometry": geometries_geoarrow} | ||
| ) | ||
| metadata["columns"]["geometry"]["encoding"] = geometry_type.lower() | ||
|
jorisvandenbossche marked this conversation as resolved.
|
||
| table = table.replace_schema_metadata({"geo": json.dumps(metadata)}) | ||
| pq.write_table(table, HERE / f"data-{geometry_type.lower()}-encoding_native.parquet") | ||
|
jorisvandenbossche marked this conversation as resolved.
|
||
|
|
||
|
|
||
| # point | ||
|
|
||
| geometries_wkt = [ | ||
| "POINT (30 10)", | ||
| "POINT EMPTY", | ||
| ] | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should there also be a version of these that contain NULLs or a version that contains Z values?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added some null values! |
||
|
|
||
| point_type = pa.struct( | ||
| [ | ||
| pa.field("x", pa.float64(), nullable=False), | ||
| pa.field("y", pa.float64(), nullable=False) | ||
| ] | ||
| ) | ||
| geometries = pa.array([(30, 10), (float("nan"), float("nan"))], type=point_type) | ||
|
|
||
| write_encoding_files( | ||
| geometries_wkt, geometries, geometry_type="Point" | ||
|
jorisvandenbossche marked this conversation as resolved.
|
||
| ) | ||
|
|
||
| # linestring | ||
|
|
||
| geometries_wkt = [ | ||
| "LINESTRING (30 10, 10 30, 40 40)", | ||
| "LINESTRING EMPTY", | ||
| ] | ||
|
|
||
| linestring_type = pa.list_(pa.field("vertices", point_type, nullable=False)) | ||
| geometries = pa.array( | ||
| [[(30, 10), (10, 30), (40, 40)], []], type=linestring_type) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe it would be less error-prone to construct these geometries from the WKT? Then we don't have to manually check that the WKT is equivalent to here. Or maybe it would be better to use GeoJSON and pyarrow's JSON reader to infer geometry columns? Though then you'd need to convert from interleaved to separated coords, which is a bit involved for this test data here 😕
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I actually tried to automate writing this hard-coded data a bit, by parsing the WKT with shapely and converting to GeoJSON. The main problem is that then I need to convert the inner lists to tuples (as json is only lists), to have the construction as a separated struct type work with pyarrow (a tuple element can be converted to a struct, but a list element not). And that gives some convoluted logic .. |
||
|
|
||
| write_encoding_files( | ||
| geometries_wkt, geometries, geometry_type="LineString" | ||
|
jorisvandenbossche marked this conversation as resolved.
|
||
| ) | ||
|
|
||
| # polygon | ||
|
|
||
| geometries_wkt = [ | ||
| "POLYGON ((30 10, 40 40, 20 40, 10 20, 30 10))", | ||
| "POLYGON ((35 10, 45 45, 15 40, 10 20, 35 10), (20 30, 35 35, 30 20, 20 30))", | ||
| "POLYGON EMPTY", | ||
| ] | ||
|
|
||
| polygon_type = pa.list_( | ||
| pa.field("rings", pa.list_( | ||
| pa.field("vertices", point_type, nullable=False) | ||
| ), nullable=False) | ||
| ) | ||
| geometries = pa.array( | ||
| [ | ||
| [[(30.0, 10.0), (40.0, 40.0), (20.0, 40.0), (10.0, 20.0), (30.0, 10.0)]], | ||
| [[(35.0, 10.0), (45.0, 45.0), (15.0, 40.0), (10.0, 20.0), (35.0, 10.0)], | ||
| [(20.0, 30.0), (35.0, 35.0), (30.0, 20.0), (20.0, 30.0)]], | ||
| [], | ||
| ], | ||
| type=polygon_type | ||
| ) | ||
|
|
||
| write_encoding_files( | ||
| geometries_wkt, geometries, geometry_type="Polygon" | ||
|
jorisvandenbossche marked this conversation as resolved.
|
||
| ) | ||
|
|
||
| # multipoint | ||
|
|
||
| geometries_wkt = [ | ||
| "MULTIPOINT ((30 10))", | ||
| "MULTIPOINT ((10 40), (40 30), (20 20), (30 10))", | ||
| "MULTIPOINT EMPTY", | ||
| ] | ||
|
|
||
| multipoint_type = pa.list_(pa.field("points", point_type, nullable=False)) | ||
| geometries = pa.array( | ||
| [ | ||
| [(30.0, 10.0)], | ||
| [(10.0, 40.0), (40.0, 30.0), (20.0, 20.0), (30.0, 10.0)], | ||
| [] | ||
| ], | ||
| type=multipoint_type | ||
| ) | ||
|
|
||
| write_encoding_files( | ||
| geometries_wkt, geometries, geometry_type="MultiPoint" | ||
|
jorisvandenbossche marked this conversation as resolved.
|
||
| ) | ||
|
|
||
| # multilinestring | ||
|
|
||
| geometries_wkt = [ | ||
| "MULTILINESTRING ((30 10, 10 30, 40 40))", | ||
| "MULTILINESTRING ((10 10, 20 20, 10 40), (40 40, 30 30, 40 20, 30 10))", | ||
| "MULTILINESTRING EMPTY", | ||
| ] | ||
|
|
||
| multilinestring_type = pa.list_( | ||
| pa.field("linestrings", linestring_type, nullable=False) | ||
| ) | ||
| geometries = pa.array( | ||
| [ | ||
| [[(30.0, 10.0), (10.0, 30.0), (40.0, 40.0)]], | ||
| [[(10.0, 10.0), (20.0, 20.0), (10.0, 40.0)], | ||
| [(40.0, 40.0), (30.0, 30.0), (40.0, 20.0), (30.0, 10.0)]], | ||
| [], | ||
| ], | ||
| type=multilinestring_type | ||
| ) | ||
|
|
||
| write_encoding_files( | ||
| geometries_wkt, geometries, geometry_type="MultiLineString" | ||
|
jorisvandenbossche marked this conversation as resolved.
|
||
| ) | ||
|
|
||
| # multipolygon | ||
|
|
||
| geometries_wkt = [ | ||
| "MULTIPOLYGON (((30 10, 40 40, 20 40, 10 20, 30 10)))", | ||
| "MULTIPOLYGON (((30 20, 45 40, 10 40, 30 20)), ((15 5, 40 10, 10 20, 5 10, 15 5)))", | ||
| "MULTIPOLYGON (((40 40, 20 45, 45 30, 40 40)), ((20 35, 10 30, 10 10, 30 5, 45 20, 20 35), (30 20, 20 15, 20 25, 30 20)))", | ||
| "MULTIPOLYGON EMPTY", | ||
| ] | ||
|
|
||
| multipolygon_type = pa.list_(pa.field("polygons", polygon_type, nullable=False)) | ||
| geometries = pa.array( | ||
| [ | ||
| [[[(30.0, 10.0), (40.0, 40.0), (20.0, 40.0), (10.0, 20.0), (30.0, 10.0)]]], | ||
| [[[(30.0, 20.0), (45.0, 40.0), (10.0, 40.0), (30.0, 20.0)]], | ||
| [[(15.0, 5.0), (40.0, 10.0), (10.0, 20.0), (5.0, 10.0), (15.0, 5.0)]]], | ||
| [[[(40.0, 40.0), (20.0, 45.0), (45.0, 30.0), (40.0, 40.0)]], | ||
| [[(20.0, 35.0), (10.0, 30.0), (10.0, 10.0), (30.0, 5.0), (45.0, 20.0), (20.0, 35.0)], | ||
| [(30.0, 20.0), (20.0, 15.0), (20.0, 25.0), (30.0, 20.0)]]], | ||
| [], | ||
| ], | ||
| type=multipolygon_type | ||
| ) | ||
|
|
||
| write_encoding_files( | ||
| geometries_wkt, geometries, geometry_type="MultiPolygon" | ||
|
jorisvandenbossche marked this conversation as resolved.
|
||
| ) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look like .csv files to me...should they have a .csv extension?