Skip to content

Migration of the GeoParquet specification to the official OGC templates - #224

Open
m-mohr wants to merge 12 commits into
mainfrom
ogc-template
Open

Migration of the GeoParquet specification to the official OGC templates#224
m-mohr wants to merge 12 commits into
mainfrom
ogc-template

Conversation

@m-mohr

@m-mohr m-mohr commented May 29, 2024

Copy link
Copy Markdown
Collaborator

Based on #219 and #206. Original author is @ghobona.
Making this a draft for now because the CI is failing, but I don't have the time and knowledge about metanorma to fix this.

Adds back the following commits:

The docs may need to be updated with the commits that were merged afterwards:
fe3687d...main

…t template (#206)

* initial metanorma conversion

* conversion to metanorma format completed

* Update README.adoc

* Update README.adoc

* Update annex-history.adoc
@kylebarron

Copy link
Copy Markdown
Collaborator

The CI only checks that there's a single newline at the end of each file, and that there are no superfluous whitespace characters at the end of each line.

If you run pre-commit run --all-files locally (after pip install pre-commit), then it will apply the fixes locally; you just have to commit them.

@m-mohr

m-mohr commented May 29, 2024

Copy link
Copy Markdown
Collaborator Author

That was too easy, lol. Thanks, @kylebarron.

@cholmes

cholmes commented May 29, 2024

Copy link
Copy Markdown
Member

Thanks @m-mohr. I'll try to edit the readme today, and take it out of draft status.

@cholmes cholmes self-assigned this May 29, 2024
@cholmes
cholmes marked this pull request as ready for review June 1, 2024 00:28
@cholmes

cholmes commented Jun 1, 2024

Copy link
Copy Markdown
Member

Ok, I think this is ready for review now. I updated the readme to try to explain what's going on, and put in more links.

I am leaning towards just removing the extra folders on images, figures and code, and it seems like if we want those later we can add them back in.

I think we ideally get this merged back in pretty soon, and then can continue to iterate on main, so that the OGC docs can continue to build.

@m-mohr

m-mohr commented Jun 1, 2024

Copy link
Copy Markdown
Collaborator Author

@cholmes The docs probably need to be updated with the commits that were merged afterwards:
fe3687d...main
Did you do that already?

@cholmes

cholmes commented Jun 1, 2024

Copy link
Copy Markdown
Member

I think most of those are not needed? This just targets 1.0, so we don’t want the latest changes to 1.1. Though I should probably make that a bit more clear, I still need to update the section on ‘authoring’.

@m-mohr

m-mohr commented Jun 7, 2024

Copy link
Copy Markdown
Collaborator Author

Oh, this is meant to target 1.0 and not 1.1? Is that ensured that there are no 1.1 changes in the docs?

@cholmes

cholmes commented Jun 8, 2024

Copy link
Copy Markdown
Member

Yeah, it's for 1.0. Good point that we should be sure there are no 1.1 things that are in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants