Skip to content

Added geospatial functions implemented in PostGIS, Spatialite and H2GIS. #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 28 commits into
base: geosparql-1.3
Choose a base branch
from

Conversation

ar-chad
Copy link
Collaborator

@ar-chad ar-chad commented Feb 19, 2025

@situx
Copy link
Collaborator

situx commented Mar 5, 2025

@ar-chad The table looks good. But why does it only include alignments for functions that already exist in GeoSPARQL? Would it not be interesting also to see functions that are missing in GeoSPARQL but which are present in the other databases?

@ar-chad
Copy link
Collaborator Author

ar-chad commented Mar 5, 2025

@situx sure, I can add anything else from ttl that does not match any of the GeoSPARQL functions. No problem.

@jabhay jabhay marked this pull request as draft March 19, 2025 20:38
@ar-chad ar-chad requested review from situx and mperry455 April 7, 2025 13:48
@ar-chad
Copy link
Collaborator Author

ar-chad commented Apr 7, 2025

@situx sure, I can add anything else from ttl that does not match any of the GeoSPARQL functions. No problem.

done now ✅ and ready for review 👀

@situx
Copy link
Collaborator

situx commented Apr 7, 2025

I addded prefixes and camelCase for the GeoSPARQL functions

@mperry455
Copy link
Collaborator

I have not had time for a detailed review yet, but some GeoSPARQL functions are missing, for example geof:is3D, geof:isMeasured, geof:coordinateDimension, and some like geof:within are not in the spec - should be geof:sfWithin instead.

Should this include functions in GeoSPARQL that do not exist in other spatial databases, for example geof:geometryType?

@ar-chad ar-chad closed this Apr 22, 2025
@ar-chad
Copy link
Collaborator Author

ar-chad commented Apr 22, 2025

I have not had time for a detailed review yet, but some GeoSPARQL functions are missing, for example geof:is3D, geof:isMeasured, geof:coordinateDimension, and some like geof:within are not in the spec - should be geof:sfWithin instead.

Should this include functions in GeoSPARQL that do not exist in other spatial databases, for example geof:geometryType?

is3D, isMeasured and coordinateDimension did not match because they are not in functions.ttl which was used to do the matching.

geof:sfWithin has skos:prefLabel "within" and this is how it was matched.

I am not voting to include all GeoSPARQL functions in this table, because it will be a duplication of already existing information. But I will be able to add them, if others vote for it.

@ar-chad ar-chad reopened this Apr 22, 2025
@mperry455
Copy link
Collaborator

mperry455 commented Apr 30, 2025

Per 4/30/2025 SWG Meeting, we need to:

  1. Replace preferred name with function URI (@situx to look at this one)
  2. Create two versions of the table:
    a) Whitepaper version: also contains GeoSPARQL functions that do not appear in any 3D Spatial DB
    b) GeoSPARQL spec version: does not contain GeoSPARQL functions that do not appear in any 3D Spatial DB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants