-
Notifications
You must be signed in to change notification settings - Fork 21
556 geometry extrusion #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: geosparql-1.3
Are you sure you want to change the base?
Conversation
|
|
==== | ||
Implementations shall support the functions | ||
<<Function: geof:extrude, `geof:extrude`>> | ||
<<Function: geof:extrudeInTime, `geof:extrudeInTime`>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
geof:extrudeToHeight needs to be added here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
---- | ||
|
||
The function http://www.opengis.net/def/function/geosparql/extrudeToHeight[`geof:extrudeToHeight`] returns a spatial Feature with a 3D geometric object that represents all Points in the extruded form of 2D `geometry` where the `height` marks the distance between points of the base `geometry` and ending points of the extruded form in space. Calculations are in the spatial reference system of `geometry`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if "distance" may be a little vague here. What about something like where the 'height' indicates Z values for points at the "top" of the extruded 3D geometry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mperry455 I corrected this accordingly to your suggestion. It is also aligned with H2GIS example http://www.h2gis.org/docs/1.5.0/ST_Extrude/
|
The only implementation in open source databases I found was H2GIS, which adds the height to the Z coordinates. http://www.h2gis.org/docs/1.5.0/ST_Extrude/ They provide only example of that when Z is 0, but it doesn't always have to be and it does not have to be the same value for all Z coordinates of the base geometry. |
We proposed the following naming changes during the 4/30/2025 SWG meeting to avoid misunderstanding of function behavior based on function name. extrudeToHeight() could be confusing if initial Z coordinate values were non-zero.
|
✅ 1. extrude() -> extrudeByLine() Done and ready for review a19e1fa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
#556