Repository navigation
cleanup(rdna): drop leftover runtime debug probes - #103
Merged
Merged
Conversation
3 of 4 tasks
Remove log-only debug gates that do nothing when unset: the unused poolwatch helper, VLLM_MAMBA_COPY_DEBUG, VLLM_BT_DEBUG, and DBG_VLLM_STEP_TIMING. phase_timer and the GDN/QSA debug knobs stay. Co-authored-by: Cursor Agent <cursoragent@cursor.com>
cursor
Bot
force-pushed
the
cursor/drop-leftover-runtime-debug-5ad3
branch
from
October 16, 2026 15:28
4e3aea0 to
55dffa2
Compare
BlivionIaG
marked this pull request as ready for review
October 16, 2026 15:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Subtraction-only removal of leftover runtime debug that only logged when an env var was set. With those vars unset, the serving path is unchanged.
phase_timer(VLLM_RDNA_PHASE_TIMING) stays.VLLM_GDN_NAN_DEBUGandVLLM_QSA_RDNA2_DEBUGstay.Not a duplicate. Open PRs were checked before editing:
VLLM_GDN_NAN_DEBUGandVLLM_QSA_RDNA2_DEBUG, which this PR keeps.envs.pyknobs and_custom_ops.py. This PR only deletes the unreadDBG_VLLM_STEP_TIMINGentry at the old lines 1445-1447. Those perf(rdna2): opt-in MoE skinny v2 decode, M=16 decode kernels, small-op pass (port of leapdragon) #57 additions are not in this diff.mamba_utils.py,worker/utils.py,gpu/block_table.py, andenvs.pyis empty. Itstuning.mdinsert is the hybrid-model rows near line 102. This edit is the diagnostics paragraph near line 217.tuning.md(old lines 207-209). This PR does not touch that note.docs/rdna2/v0.31.0-port-notes.md. That file still namesVLLM_BT_DEBUG,VLLM_MAMBA_COPY_DEBUG, andDBG_VLLM_STEP_TIMINGin the "still read" list. It was not edited here.AI assistance was used (Cursor Grok 4.7). A human should review every line. No model-output change is expected, so no model eval was run.
Removed
vllm/utils/rocm_poolwatch.py. Nothing imported it.rgbefore delete matched only that file.VLLM_RDNA_POOLWATCH(_HISTORY,_DUMP_ON_REPLAY) indocs/rdna2/tuning.md. The same paragraph no longer listsVLLM_BT_DEBUG,VLLM_MAMBA_COPY_DEBUG, orDBG_VLLM_STEP_TIMING.VLLM_MAMBA_COPY_DEBUGlog branches invllm/v1/worker/mamba_utils.py(create, collect, preprocess). Copy indexing is unchanged.VLLM_BT_DEBUGlogs invllm/v1/worker/utils.py,vllm/v1/worker/gpu/model_runner.py, andvllm/v1/worker/gpu/block_table.py. Zeroing and copy-on-write still run.gather_block_tablesstill returns the same tuple.DBG_VLLM_STEP_TIMING:_DbgPhase,_dbg_flush_step, the preprocess wrapper, the flush calls, the banner, and the unreadenvs.pyentry.phase_timercalls are untouched.Lines removed are from the fork delta (BlivionIaG /
kev29lt@gmail.com, including the block-table probe in the port commit he committed). Upstream zeroing, copy-on-write, andpreprocess_statestay.Test Plan
tests/conftest.pyimports torch, transformers, andvllm.LLM, so the env suite was run with--noconftest. Mamba worker tests import Triton and the GPU model-state stack and were not run.Test Result
rgovervllm/anddocs/rdna2/tuning.md: no matches.Remaining name hits, left on purpose:
docs/rdna2/v0.31.0-port-notes.mdlines 79 and 256 (docs(rdna): drop stale serve instructions #102 owns that file; line 79 is its hunk).bench_results/2026-10-02_pr34-fa-prefill-d128/remote/src/{patched,baseline}/rdna_attn.py.py_compileon the five edited modules: exit 0.ruff0.14.0 check andformat --checkon those modules: all passed, already formatted.pytest tests/test_envs.py --noconftest(CPU torch, uv venv, no system pip): 54 passed, 3 failed. The pass set includestest_getattr_with_cache, which evaluates every remaining environment-variable getter. The 3 failures areModuleNotFoundError: No module named 'zmq'insidecompile_factors()/SamplingParams(vllm/utils/network_utils.py), not the deleted debug gates.GPU check needed
On gfx1030, greedy hybrid smoke (Flash-Next or another GDN/mamba recipe) with every removed env unset, plus one serve log line from
VLLM_RDNA_PHASE_TIMINGto confirmphase_timerstill prints. No model eval was run here.