Skip to content

[WIP] use the prebuilt images from ghcr when running tests - #1600

Draft
suricactus wants to merge 8 commits into
masterfrom
QF-4996-faster-ci-vol666
Draft

[WIP] use the prebuilt images from ghcr when running tests#1600
suricactus wants to merge 8 commits into
masterfrom
QF-4996-faster-ci-vol666

Conversation

@suricactus

Copy link
Copy Markdown
Collaborator

No description provided.

@duke-nyuki

Copy link
Copy Markdown
Collaborator

@suricactus
suricactus force-pushed the QF-8228-check-tmpl branch from 041693d to 74f5a8c Compare May 11, 2026 09:03
@suricactus
suricactus force-pushed the QF-4996-faster-ci-vol666 branch from d93a219 to c8fdbf0 Compare May 11, 2026 22:59
@suricactus
suricactus force-pushed the QF-8228-check-tmpl branch from 3693772 to 6e9e878 Compare May 11, 2026 23:00
@suricactus
suricactus force-pushed the QF-4996-faster-ci-vol666 branch from c8fdbf0 to 222a80b Compare May 11, 2026 23:01
Base automatically changed from QF-8228-check-tmpl to master May 11, 2026 23:31
@suricactus
suricactus force-pushed the QF-4996-faster-ci-vol666 branch 2 times, most recently from 3dcbf98 to 8018e78 Compare May 12, 2026 15:07
Comment thread .github/workflows/ci.yml
@suricactus
suricactus force-pushed the QF-4996-faster-ci-vol666 branch 2 times, most recently from b90b753 to 69dccfc Compare May 20, 2026 20:59

@gounux gounux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks promising !

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml Outdated
Before we only had `enable_dockerhub` which was used for multiple things.

- Added `enable_ghcr: true` to each matrix service.
- Kept `enable_dockerhub` separate.
- GHCR metadata is now controlled by `enable_ghcr`.
- GHCR login only runs when `enable_ghcr` is true.
- `commit-<short-sha>` tags are no longer PR-only:
- always push to ghcr.io

Needed because we depend on the app to run as a production like app,
but we are missing gunicorn as a dependency.
…waiting for 30x20 secs)

- Added `classic/docker-compose.override.ci.yml` to replace local builds with GHCR images.
- Updated `classic/.github/workflows/test.yml` with packages: read permission. Required to read from ghcr.
- PR tests use the PR head SHA instead of the synthetic merge SHA.
- Added a special YAML check for `classic/docker-compose.override.ci.yml`
@suricactus
suricactus force-pushed the QF-4996-faster-ci-vol666 branch from 69dccfc to fcd0379 Compare May 21, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants