chore: remove growthbook from payment functions #8947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin9foong
force-pushed
the
chore/remove-gb-from-payments-functions
branch
from
df3cea6 to
d1ca7b2
Compare
KenLSM
approved these changes
Dec 8, 2025
eliotlim
approved these changes
Dec 8, 2025
Contributor
eliotlim
left a comment
eliotlim
left a comment
There was a problem hiding this comment.
thanks for deprecating unused feature flags and mechanisms!
good stuff 💯
Base automatically changed from
feat/remove-deprecated-email-submission-route
to
develop
December 8, 2025 07:31
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since pdf local is no longer in use and pdf lambda is used, the growthbook flag is no longer in use. Hence, growthbook no longer needs to be passed to payments functions.
Closes FRM-2208
Solution
Remove passing of growthbook to payments functions.
Breaking Changes
No - this PR is backwards compatible