Skip to content

feat: add ogp logo header #8954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eliotlim merged 2 commits into from
Dec 10, 2025
Merged

feat: add ogp logo header #8954

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f612864
feat: add ogp logo header
eliotlim Dec 8, 2025
ae366b2
Merge branch 'develop' into feat/add-ogp-logo-header
eliotlim Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions frontend/src/features/public-form/components/FormLogo/FormBannerLogo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { useEffect, useMemo, useState } from 'react'
import { BiImage } from 'react-icons/bi'
import {
Box,
Divider,
Flex,
Grid,
Icon,
Expand All @@ -11,9 +12,13 @@ import {
Stack,
Text,
} from '@chakra-ui/react'
import { useFeatureValue } from '@growthbook/growthbook-react'

import { featureFlags } from '~shared/constants'
import { FormColorTheme } from '~shared/types'

import { OgpLogoFull } from '~assets/svgrs/brand/OgpFullLogo'

import { FormLogoutButton } from './FormLogoutButton'

export interface FormBannerLogoProps {
Expand Down Expand Up @@ -79,21 +84,33 @@ export const FormBannerLogo = ({
}
}, [fallbackType, logoImgSrc])

const enableOgpHeader = useFeatureValue(featureFlags.ogpHeader, false)

if (!hasLogo && !isLoading) return null

return (
<Grid p="1rem" bg="white" gridTemplateColumns="1fr auto 1fr">
<Spacer />
<Flex maxW="57rem">
<Image
fallback={fallback}
onLoad={() => setFallbackType('loaded')}
onError={() => setFallbackType('error')}
src={logoImgSrc}
alt={logoImgAlt}
minH="1.25rem"
maxH="4rem"
/>
<Flex alignItems={'center'} justifyContent="center" px={4}>
<Flex maxW="57rem">
<Image
fallback={fallback}
onLoad={() => setFallbackType('loaded')}
onError={() => setFallbackType('error')}
src={logoImgSrc}
alt={logoImgAlt}
minH="1.25rem"
maxH="4rem"
/>
</Flex>
{enableOgpHeader && (
<>
<Divider orientation="vertical" />
<Box ml={3}>
<OgpLogoFull fontStyle={'3rem'} height={`3rem`} />
</Box>
</>
)}
</Flex>
<FormLogoutButton
colorScheme={`theme-${colorTheme}`}
Expand Down
1 change: 1 addition & 0 deletions shared/constants/feature-flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,5 @@ export const featureFlags = {
singpassMrf: 'singpass-mrf' as const,
enableSaveDraftButtonFloating: 'enable-save-draft-button-floating' as const,
enableSaveDraftButtonHeader: 'enable-save-draft-button-header' as const,
ogpHeader: 'enable-ogp-header' as const,
}
Loading