chore: remove sgid #2394
Merged
chore: remove sgid #2394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangohjw
reviewed
Jul 11, 2025
| "@hapi/joi": "^17.1.1", | ||
| "@material-ui/core": "^4.11.4", | ||
| "@material-ui/lab": "^4.0.0-alpha.61", | ||
| "@opengovsg/sgid-client": "^2.0.0", |
Contributor
There was a problem hiding this comment.
missing update for package-lock.json?
Contributor
|
bugbot run |
dcshzj
previously approved these changes
Jul 11, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ BugBot reviewed your changes and found no bugs!
BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
There was a problem hiding this comment.
Pull Request Overview
This PR removes all SGID-related code and configuration since it is no longer used.
- Deleted SGID service, controller, routes, and client page
- Removed SGID configuration, dependency, and environment variables
- Cleared SGID bindings and exports
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/server/services/sgid.ts | Deleted SGID service implementation |
| src/server/modules/auth/ | Removed SGID login controller and exports |
| src/server/inversify.config.ts | Unbound and removed SGIDLoginController binding |
| src/server/constants.ts | Removed SGIDLoginController symbol |
| src/server/config.ts | Removed SGID-related env config |
| src/server/api/sgidLogin/index.ts | Deleted SGID login API routes |
| src/server/api/index.ts | Unregistered SGIDLogin route |
| src/client/sgidLogin/index.tsx | Deleted SGIDLoginPage component |
| src/client/app/util/types.ts | Removed SGID login route constant |
| src/client/app/components/pages/... | Removed SGIDLoginPage import and route |
| package.json | Removed @opengovsg/sgid-client dependency |
| docker-compose.yml | Removed SGID env var and adjusted port quoting |
Comments suppressed due to low confidence (1)
docker-compose.yml:112
- [nitpick] The quoting style for the port mapping changed from double to single quotes; consider using a consistent style throughout the file for readability.
- '1080:80'
adriangohjw
approved these changes
Aug 21, 2025
dcshzj
added a commit
that referenced
this pull request
Aug 21, 2025
* feat: start writing RedirectionDestination in redis cache (#2407) * chore: remove sgid (#2394) * chore: delete sgid files * chore: remove sgid * chore: update package lock * 1.84.0 --------- Co-authored-by: seaerchin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
we want to remove sgid cos it's no longer used
Solution
remove any mention of sgid in our codebase