Skip to content

fix: lowercase urls to prevent bypass #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seaerchin merged 3 commits into from
Dec 9, 2025
Merged

fix: lowercase urls to prevent bypass #2419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3ada12
fix: lowercase urls to prevent bypass
seaerchin Dec 4, 2025
6a8583e
chore: write tests
seaerchin Dec 9, 2025
8f07f27
chore: npm i
seaerchin Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 45 additions & 25 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/shared/util/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export function isWhitelisted(url: string): boolean {

// Checks if url is blacklisted.
export function isBlacklisted(url: string): boolean {
return blacklist.some((bl) => url.includes(bl))
return blacklist.some((bl) => url.toLowerCase().includes(bl))
}

// Tests if a URL string begins with https://.
Expand Down
10 changes: 10 additions & 0 deletions test/shared/util/validation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ describe('Test whiteliste check', () => {
})

describe('Test blacklist check', () => {
test('example GooGle.com url is not blacklisted', () => {
const url = 'https://www.GooGle.com'
expect(validation.isBlacklisted(url)).toBe(false)
})

test('localstack url is not blacklisted', () => {
const url = 'http://localhost:4566'
expect(validation.isBlacklisted(url)).toBe(false)
Expand All @@ -18,6 +23,11 @@ describe('Test blacklist check', () => {
const url = 'https://bit.ly/abc'
expect(validation.isBlacklisted(url)).toBe(true)
})

test('example Bit.Ly url is also blacklisted', () => {
const url = 'https://Bit.Ly/abc'
expect(validation.isBlacklisted(url)).toBe(true)
})
})

describe('Test https check', () => {
Expand Down
Loading