Skip to content

feat: add ci checks #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2024
Merged

feat: add ci checks #5

merged 3 commits into from
Dec 9, 2024

Conversation

zhongliang02
Copy link
Contributor

@zhongliang02 zhongliang02 commented Dec 9, 2024

Context

This repo contains a custom codeql config which is used by some repos in their workflows.
In a previous incident, updating the codeql config resulted in failures in another project's pipeline.

Approach

This PR adds a ci.yml that is similar to what other repos use in their codeql workflow.

  • It checks out itself as the base repo to run codeql on.
  • It then runs codeql with the updated config, so any errors in the config will cause the workflow to fail.
  • This workflow will run for all PRs.

If the workflow succeeds, it means that the configuration will not break builds in the future (barring the removal of codeql packs from our container registry)

We should make sure that merging is blocked if this workflow fails.

Testing

Will test with a nonexistent codeql pack afterwards

@zhongliang02 zhongliang02 requested a review from a team December 9, 2024 01:30
@zhongliang02 zhongliang02 merged commit 7b3075f into develop Dec 9, 2024
2 checks passed
@zhongliang02 zhongliang02 deleted the feat/add-ci-checks branch December 9, 2024 02:05
@zhongliang02
Copy link
Contributor Author

Test case:
#6 is blocked from merging.

@zhongliang02 zhongliang02 removed the request for review from a team December 11, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant