Skip to content

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented May 28, 2025

Changes

  1. Fix postman SMS retries
  2. Export more components for plumber-admin

Release Steps

  • Lower tasks to 4
  • Deploy
  • Increase tasks back to 8 then 12

## Problem

Plumber Admin is unable to view editor settings page for notifications
and flow transfer

## Solution

This PR exports the relevant components for plumber-admin
## Problem
Postman SMS retriable error was re-wrapped with StepError resulting in
no retries

## Solution
Dont re-catch and wrap this error
@pregnantboy pregnantboy requested a review from a team as a code owner May 28, 2025 11:11
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, lets go 👍

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented May 28, 2025

Datadog Report

Branch report: develop-v2
Commit report: 52663b1
Test service: plumber

✅ 0 Failed, 775 Passed, 0 Skipped, 2m 26.34s Total Time
➡️ Test Sessions change in coverage: 1 no change

@pregnantboy pregnantboy merged commit bb38ab4 into production May 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants