Release v1.42.2 #1024
Merged
Release v1.42.2 #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kevinkim-ogp
commented
May 30, 2025
kevinkim-ogp
commented
- Add additional logging for worker status
- Add retries for Postman email and SMS
## Changes Adding additional logging for redis connection error and worker status for `closed` and `ready`. For debugging `failed to refresh slots cache` error.
## TL;DR Add retry handling for the following transient errors: * Postman Email: 500, 524, socket hang up * Postman SMS: 500, 502, 503, read TIMEOUT ## Why make this change? Postman Email and SMS services occasionally return transient errors due to server instability or network issues. These errors are often resolved on subsequent attempts. By retrying affected executions before marking them as failed, we improve overall system resilience and reduce false failure rates in Plumber. ## How to test? - Change the local postman URL to call https://mock.codes - Use a URL param to point to the different http codes - Verify that RetriableError is thrown
Datadog ReportBranch report: ✅ 0 Failed, 779 Passed, 0 Skipped, 2m 22.51s Total Time |
pregnantboy
approved these changes
May 30, 2025
Contributor
pregnantboy
left a comment
pregnantboy
left a comment
There was a problem hiding this comment.
lgtm: postman-sms-qps lowered to 25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.