Skip to content

Conversation

@kevinkim-ogp
Copy link
Contributor

  • UI Revamp: Side drawer
  • Fix: update notifications selection on save

m0nggh and others added 3 commits June 2, 2025 13:17
## Problem

Right now, the editor notifications doesn't update upon changing the
dropdown input

## Solution
Update the cache and the fields for the graphql mutation

## Tests
- [ ] Updating flow config works for notifications
- [ ] Updating flow still works in the editor
## TL;DR
This is the UI revamp to move from accordions to side drawer

## What changed?
PLU-440 [SIDE-DRAWER-1]: move accordions to side drawer (#910) 
PLU-443 [SIDE-DRAWER-2]: Save + Complete step buttons (#911) 
PLU-452 [SIDE-DRAWER-3]: If-then revamp (#924) 
PLU-377 [SIDE-DRAWER-4]: Rename step (#935) 
[SIDE-DRAWER-5]: Pipe and Tile rename (#950) 
PLU-383 [SIDE-DRAWER-6]: Remove accordions (#955) 
PLU-442 [SIDE-DRAWER-7]: Convert MultiRow to MultiRow-MultiCol (#963) 
[SIDE-DRAWER-8] Post bugbash UI fixes - Part 1 (#970) 
chore: warn on unsaved changes
chore: warn on browser reload or close
chore: warn on adding new step
chore: warn on adding new if-then step
chore: update copywriting
chore: update based on pr comments
[SIDE-DRAWER-10] Custom step name in Suggestions popover (#979) 
[SIDE-DRAWER-11] Improve side drawer motion (#980) 
[SIDE-DRAWER-12] Post bugbash UI nits - Part 2 (#981) 
[SIDE-DRAWER-13] Invalidate step variables (#983) 
[SIDE-DRAWER-14] Fix UI flickers (#984) 
[SIDE-DRAWER-15] UI fixes - Part 3 (#988) 
[SIDE-DRAWER-16] If-then add and delete step behaviour (#989) 
[SIDE-DRAWER-17] Reset fields properly on discard change (#993) 
[SIDE-DRAWER-18] Allow reset to default step name (#994) 
[SIDE-DRAWER-19] Backward compability of variable validation (#995) 
[SIDE-DRAWER-20] UI fixes - Part 4 (#996) 
[SIDE-DRAWER-21] Refine save and check step (#999) 
[SIDE-DRAWER-22] Improve builder guidance (#1000) 
[SIDE-DRAWER-23]: Editor background dotted pattern (#1001) 
[SIDE-DRAWER-24]: UI fixes - Part 5 (#1002) 
[SIDE-DRAWER-25]: Fix PaySG schema (#1003) 
[SIDE-DRAWER-26]: Disable vertical scroll for multirow-multicol RTE (#… 
[SIDE-DRAWER-27]: Improve side drawer sliding motion (#1009) 
[SIDE-DRAWER-28]: Remove unused code (#1010) 
[SIDE-DRAWER-30]: update for e2e test (#1015) 
PLU-479: [SIDE-DRAWER-29]: add announcement modal (#1014) 
[SIDE-DRAWER-31]: Mobile repsonsiveness (#1016)

---------

Co-authored-by: Ong Guan Hong Malcolm <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
Co-authored-by: m0nggh <[email protected]>
@kevinkim-ogp kevinkim-ogp requested a review from a team as a code owner June 2, 2025 06:16
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jun 2, 2025

Datadog Report

Branch report: develop-v2
Commit report: a88f315
Test service: plumber

✅ 0 Failed, 795 Passed, 0 Skipped, 2m 35.54s Total Time
➡️ Test Sessions change in coverage: 1 no change

## Problem
Bug causing UI issue when the only action in the pipe is an 'Only
continue if' action

## Solution
Update check for non-grouped actions


## Before & After Screenshots

**BEFORE**:
<img width="1629" alt="Screenshot 2025-06-02 at 2 41 38 PM"
src="https://github.com/user-attachments/assets/f24090ab-7c45-4437-af82-e193f17448b7"
/>


**AFTER**:
<img width="1512" alt="Screenshot 2025-06-02 at 2 42 52 PM"
src="https://github.com/user-attachments/assets/f6fe9e54-c516-4e12-9173-824485045e4d"
/>
Copy link
Contributor

@m0nggh m0nggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job with the huge pr, lgtm sir

@kevinkim-ogp kevinkim-ogp merged commit cd5c5ca into production Jun 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants