Skip to content

Conversation

@kevinkim-ogp
Copy link
Contributor

TL;DR

Adds dropdown to select the type of generalised model to use for AISAY action.
Context: AISAY added a new model type called 'Vision' to their generalised model.

AISAY's API doc: https://app.swaggerhub.com/apis-docs/DAMIENSKTWORK/bgp-aisay_document_extraction_api/1.0.11#/DocumentParserResponse

Solution

Improvements:

  • Add dropdown to select generalised model: Standard (default) or Vision (new)

How to test?

  • Existing AISAY actions work as intended without making any changes
    • Show the model type as Standard by default
  • Existing AISAY action can be updated to use new Vision model
  • Create new AISAY action with Vision model and runs as intended
  • Create new AISAY action with Standard model and runs as intended

What changed?

  • Additional dropdown field called Model type with the following options: Standard (default), Vision (new)
  • Add tests to validate the model type selection
  • Add model type to api call as additional_features

Before & After Screenshots

BEFORE:
Screenshot 2025-06-06 at 2 49 19 PM

AFTER:
Screenshot 2025-06-06 at 2 52 50 PM

Screen.Recording.2025-06-06.at.2.45.39.PM.mov

@kevinkim-ogp kevinkim-ogp requested a review from a team as a code owner June 6, 2025 06:54
@kevinkim-ogp
Copy link
Contributor Author

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


BugBot free trial expires on June 17, 2025
You have used $0.00 of your $10.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

Copy link
Contributor

@m0nggh m0nggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested that it works for both options, lgtm

@kevinkim-ogp kevinkim-ogp force-pushed the chore/aisay/add-gen-model-type branch from 8281424 to 689e750 Compare June 11, 2025 02:49
@datadog-opengovsg
Copy link

Datadog Report

Branch report: chore/aisay/add-gen-model-type
Commit report: 689e750
Test service: plumber

✅ 0 Failed, 822 Passed, 0 Skipped, 2m 33.13s Total Time
⬆️ Test Sessions change in coverage: 1 increased (+0.05%)

@kevinkim-ogp kevinkim-ogp merged commit d2826b6 into develop-v2 Jun 11, 2025
6 checks passed
@kevinkim-ogp kevinkim-ogp deleted the chore/aisay/add-gen-model-type branch June 11, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants