-
Notifications
You must be signed in to change notification settings - Fork 8
PLU-363: hide formsg questions and re-label some fields #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 829 Passed, 0 Skipped, 2m 31.63s Total Time |
| }) | ||
|
|
||
| it('sets label and order to null if question number is undefined', async () => { | ||
| it('should computes order for questions and answers even if order is not provided', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test description has a grammatical error. It should be either "should compute order" or "computes order" rather than "should computes order".
| it('should computes order for questions and answers even if order is not provided', async () => { | |
| it('should compute order for questions and answers even if order is not provided', async () => { |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
bugbot run |
kevinkim-ogp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tested and confirmed that it works 👍

Improve FormSG Variable Display and Labeling
Problem
Users are selecting Question variables by mistake.
Solution