Skip to content

Conversation

@kevinkim-ogp
Copy link
Contributor

Problem

  • FormSG attachments are missing from test result
  • Caused by mistake during rebase

Before & After Screenshots

BEFORE:
Attachment not visible in form test result
Screenshot 2025-06-13 at 3 47 22 PM
Screenshot 2025-06-13 at 3 47 37 PM

AFTER:
Attachment(s) visible in form test result
Screenshot 2025-06-13 at 3 46 17 PM

How to test?

  • Connect your form with attachments and check step, verify that attachments appear in test result
  • Test results are displayed correctly for all other action types

@kevinkim-ogp kevinkim-ogp requested a review from a team as a code owner June 13, 2025 07:48
Copy link
Contributor

@m0nggh m0nggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested that attachment variables now show in the test output, lgtm!

@kevinkim-ogp kevinkim-ogp merged commit 567e09f into develop-v2 Jun 18, 2025
6 checks passed
@kevinkim-ogp kevinkim-ogp deleted the fix/show-all-variables-in-test-result branch June 18, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants