Skip to content

Conversation

@kevinkim-ogp
Copy link
Contributor

  • fix: update display of for-each in template
  • fix: configs for Plumber admin

## Problem
Build errors in Plumber Admin due to:
* `zod` not added as peer dependency
* default CSS name change when upgrading from Vite 4+ to 6+
  * 4+: standardised to `style.css`
* 6+: adopts the "name" in `package.json`, which creates `frontend.css`
instead

## What did it affect?
* Inputs were unstyled: RTEs, dropdowns etc
* Tiles header and columns were not fixed

## How to test?
- [ ] Pull and run locally: all inputs and pages should have the same
styling as Plumber
## Problem
For-each template was not displaying steps in the same layout as the
Editor

## What changed?
* Update to handle for-each
* Refactored / rename from IfThen content to Group content to be more
generic since both are grouped actions

## Tests
- [ ] Steps are created correctly from templates
- [ ] All other templates are displayed correctly in the preview

## Before & After Screenshots

**BEFORE**:
<img width="5088" height="3372" alt="image"
src="https://github.com/user-attachments/assets/39f49a03-9c91-4486-98ce-a68ebac7e8d0"
/>


**AFTER**:
<img width="5088" height="3372" alt="image"
src="https://github.com/user-attachments/assets/defbb02f-3374-4537-90bd-85956a100894"
/>
@kevinkim-ogp kevinkim-ogp requested a review from a team as a code owner July 21, 2025 05:47
@datadog-opengovsg
Copy link

Datadog Report

Branch report: develop-v2
Commit report: ba6619c
Test service: plumber

✅ 0 Failed, 1005 Passed, 0 Skipped, 2m 45.03s Total Time
➡️ Test Sessions change in coverage: 1 no change

@kevinkim-ogp kevinkim-ogp merged commit 15714b3 into production Jul 21, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants