Skip to content

[TILES-V2-12] : small improvements #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pregnantboy merged 3 commits into from
Jul 25, 2025
Merged

[TILES-V2-12] : small improvements #1118

pregnantboy merged 3 commits into from
Jul 25, 2025

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Jul 24, 2025 •
edited
Loading

Small tiles improvments

  • Add Table icon in breadcrumb to differentiate v2 from v1 tiles
    image.png
  • Improve cell editing functionality:
    • Allow adding line breaks with Alt+Enter
    • Change Shift+Enter to navigate upward
    • Prevent cell editing when data is being fetched
  • Fix cell selection behaviour to allow selecting substrings in cel

@pregnantboy Graphite App
Copy link
Contributor Author

pregnantboy commented Jul 24, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pregnantboy pregnantboy force-pushed the chore/allow-subselection branch from 2f5153d to 314f1cc Compare July 24, 2025 13:22
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jul 24, 2025 •
edited
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1d10974 | Was this helpful? Give us feedback!

@pregnantboy pregnantboy force-pushed the chore/allow-subselection branch from 314f1cc to 1d10974 Compare July 25, 2025 06:34
@pregnantboy pregnantboy changed the title chore: allow subselection of text in cell, change shift enter behaviour feat: add table icon and Alt+Enter line break in table cells Jul 25, 2025
@pregnantboy pregnantboy changed the title feat: add table icon and Alt+Enter line break in table cells [TILES-V-12] : add table icon and Alt+Enter line break in table cells Jul 25, 2025
@pregnantboy pregnantboy changed the title [TILES-V-12] : add table icon and Alt+Enter line break in table cells [TILES-V-12] : small improvements Jul 25, 2025
@pregnantboy pregnantboy marked this pull request as ready for review July 25, 2025 06:38
@pregnantboy pregnantboy requested a review from a team as a code owner July 25, 2025 06:38
@pregnantboy pregnantboy changed the title [TILES-V-12] : small improvements [TILES-V2-12] : small improvements Jul 25, 2025
kevinkim-ogp
kevinkim-ogp approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice enhancements!

@pregnantboy pregnantboy merged commit 45b4a55 into tiles-v2/trunk Jul 25, 2025
3 checks passed
@pregnantboy pregnantboy deleted the chore/allow-subselection branch July 25, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinkim-ogp kevinkim-ogp kevinkim-ogp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pregnantboy @kevinkim-ogp