Skip to content

Conversation

@pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Jul 25, 2025

TL;DR

This change addresses a compatibility issue between Tiles v1 and v2. In v1, empty cells were represented as empty strings or by omitting the key entirely, while in v2, empty cells return null values. This update ensures the application can properly handle data from both versions.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pregnantboy pregnantboy changed the title fix: support tiles v2 nullable cells [TILES-V2-13] fix: support tiles v2 nullable cells Jul 25, 2025
@pregnantboy pregnantboy marked this pull request as ready for review July 25, 2025 07:57
@pregnantboy pregnantboy requested a review from a team as a code owner July 25, 2025 07:57
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested and verified it works!

@datadog-opengovsg
Copy link

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 042439d | Was this helpful? Give us feedback!

@pregnantboy pregnantboy merged commit 359dbf4 into tiles-v2/trunk Jul 25, 2025
8 checks passed
@pregnantboy pregnantboy deleted the fix/support-v2-nullable-cells branch July 25, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants