PLU-532: Remove deleted FormSG attachments from email step parameters #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on July 29, 2025
Learn more in the Cursor dashboard.
| flowData, | ||
| priorExecutionSteps, | ||
| variableTypes, | ||
| [getValues, name, setError, options], |
There was a problem hiding this comment.
Bug: Validation Inconsistency with Deleted Attachments
The validateFiles function validates against unfiltered form values, while the form update operates on filtered values that exclude deleted attachments. This inconsistency causes validation (e.g., attachment limit checks) to incorrectly count deleted attachments, leading to premature failures.
kevinkim-ogp
changed the title
pregnantboy
approved these changes
Aug 4, 2025
Contributor
pregnantboy
left a comment
pregnantboy
left a comment
There was a problem hiding this comment.
verified, works! good catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A bug in the email attachments field caused attachments that were deleted from FormSG to remain in the parameters. As a result, users hit the maximum limit of 10 attachments, even though fewer than 10 were visible in the UI.
Solution
When user is making changes to the selected attachments, add a filter on the existing parameters to remove attachments that no longer exist within the FormSG that is connected.
How to test?