Skip to content

Conversation

@kevinkim-ogp
Copy link
Contributor

  • fix: cannot update for each step name if no variable
  • fix(for-each): filter iterations for IterationSelector
  • chore(robots): noindex for tiles

## Problem
Cannot update step name if there is no variable selected at the for each
step.
<img width="1506" height="804" alt="Screenshot 2025-11-27 at 5 36 03 PM"
src="https://github.com/user-attachments/assets/a50cb3b1-4074-4c42-bf77-dc9ebc5e5368"
/>


## Solution
Update schema with `.nullish()` to allow step name to be updated before
any for each variable is selected

## Test
- [ ] Can update step name before a variable is selected in the or each
input
- [ ] Validation that input must be a variable still works
## Problem
We have a rule setup on Cloudflare to prevent robots from indexing Tiles
links.
To reduce the reliance on Cloudflare we want to move the rule dependency
to our app.

## Solution
This is a fallback in case we need to turn off orange cloud in the event
of a Cloudflare outage.

**Frontend:**
Added `<meta name="robots" content="noindex,nofollow" />` to:
* Main tile viewer page
* Invalid/expired tile links
* Missing tile error page

**Backend:**
Created `robots-header.ts` - Express middleware that sets `X-Robots-Tag:
noindex, nofollow` header for all `/tiles/*` routes

Note: the meta tag should be present even if the route is invalid so
that all routes to `tiles/*` are not indexed.

## Tests
- [x]  Build and run locally: npm run build && npm start
- [ ] Verify header on tiles routes: curl -I
http://localhost:8080/tiles/123 shows X-Robots-Tag: noindex, nofollow
- [ ] Verify no header on non-tiles routes: curl -I
http://localhost:8080/flows has no X-Robots-Tag

## Screenshots
**Tile**
<img width="1920" height="970" alt="Screenshot 2025-11-28 at 3 51 56 PM"
src="https://github.com/user-attachments/assets/636c406d-9b18-4b7a-aa8a-f397e365c5f3"
/>

**Invalid Tile link**
<img width="1920" height="1013" alt="Screenshot 2025-11-28 at 3 52
27 PM"
src="https://github.com/user-attachments/assets/f81f9446-8bca-4d45-ba28-91299efee06e"
/>

**View only link**
<img width="1920" height="968" alt="Screenshot 2025-11-28 at 3 54 50 PM"
src="https://github.com/user-attachments/assets/a995384e-529c-498e-b891-2ca6d8e4566d"
/>


**Revoked view only link**

<img width="1920" height="965" alt="Screenshot 2025-11-28 at 3 56 45 PM"
src="https://github.com/user-attachments/assets/07acea2f-5e2e-4f74-9615-4de9da488089"
/>
## Problem
Executions page for each iteration selector does not take into account
the status filter applied.

## Solution
Filter the iterations for the iteration selector

## Tests
- [ ] Apply filter, should only show that status in the iteration
selector

## Before & After Screenshots

**BEFORE**:
<img width="1195" height="351" alt="Screenshot 2025-11-12 at 9 05 42 PM"
src="https://github.com/user-attachments/assets/763574c1-1b0a-437d-baf2-ad726af805c4"
/>

<img width="1196" height="355" alt="Screenshot 2025-11-12 at 9 05 50 PM"
src="https://github.com/user-attachments/assets/da94f9a9-11d0-4eb8-a8e0-692e88b10961"
/>

<img width="1198" height="356" alt="Screenshot 2025-11-12 at 9 05 58 PM"
src="https://github.com/user-attachments/assets/38f6b55a-cbae-47fd-8281-3d75b87cccd6"
/>

**AFTER**:
<img width="1201" height="400" alt="Screenshot 2025-11-12 at 9 04 32 PM"
src="https://github.com/user-attachments/assets/c2cee281-1477-43ce-9eea-e9945d0684fb"
/>


<img width="1197" height="372" alt="Screenshot 2025-11-12 at 9 04 38 PM"
src="https://github.com/user-attachments/assets/f95f95ac-e7ef-4532-b766-6739219ede8e"
/>


<img width="1201" height="397" alt="Screenshot 2025-11-12 at 9 04 46 PM"
src="https://github.com/user-attachments/assets/38d1db77-f7ee-416c-9338-4085d01569e1"
/>
@kevinkim-ogp kevinkim-ogp requested a review from a team as a code owner December 1, 2025 09:50
## Problem
Frontend bug prevents users from creating If-then.

## Solution
Return `flowId` when creating and updating steps.

## Tests
- [ ] Can create if-then at second step
- [ ] Can create if-then at third or more step
- [ ] Can create if-then inside for-each
@kevinkim-ogp kevinkim-ogp merged commit b826f09 into production Dec 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants