Skip to content

Release v1.56.4 #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevinkim-ogp merged 5 commits into from
Dec 3, 2025
Merged

Release v1.56.4 #1356

kevinkim-ogp merged 5 commits into from
Dec 3, 2025

Conversation

@kevinkim-ogp
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp commented Dec 3, 2025 •
edited
Loading

  • fix(formsg-frontend): table field preview
  • fix(pipe-transfer): filter excel steps to nullify
  • chore(slack): reduce Slack scopes

kevinkim-ogp and others added 4 commits December 3, 2025 17:13
@kevinkim-ogp @pregnantboy
PLU-624: fix(formsg-frontend): table field preview (#1355)
5f25880 
## Problem
* Forms that contain **Section** or **Image** fields cannot preview
their table rows due to a mismatch in the Zod schema.
The current schema allows `undefined`, but these field types return
`null`, which causes validation errors.
* If there is more than 1 table in the form, the preview always shows
data from the first table

## Solution
- Replace `.optional()` with `.nullish()` so that both undefined and
null are accepted.
- Fetch the table data using the variable id

## Tests
- [x] All FormSG test results display correctly
- [x] FormSG tables can be previewed correctly even when they contain
section headers or images
- [x] FormSG table previews display the correct data when there are two
or more tables

---------

Co-authored-by: Ian Chen <[email protected]>
@kevinkim-ogp
PLU-620: reduce Slack scopes (#1353)
2efa15a 
## Problem
Slack integration requests for a lot of scopes when adding the app to a
workplace.

## Solution
Use the least permissive access required.

## Other changes
Renamed auth fields to `Client ID` and `Client Secret` to match the
names on Slack.

## Tests
- [ ] Can still add app to Plumber
- [ ] Can send message to public channel as user
- [ ] Can send message to public channel as bot
  - [ ] Can set bot name
  - [ ] Can set bot icon
- [ ] Can send message to private channel as user
- [ ] Can search for messages


## Before & After Screenshots
<img width="601" height="430" alt="Screenshot 2025-12-02 at 10 56 35 AM"
src="https://github.com/user-attachments/assets/a525fe87-0540-42f8-a303-70dbce672f9c"
/>
<img width="598" height="414" alt="Screenshot 2025-12-02 at 10 56 41 AM"
src="https://github.com/user-attachments/assets/427c7e9a-dd7b-4601-8ef0-b2548d2299da"
/>
<img width="593" height="409" alt="Screenshot 2025-12-02 at 10 56 47 AM"
src="https://github.com/user-attachments/assets/22412234-5e7f-4947-8597-a1360ab59c35"
/>


<img width="615" height="687" alt="Screenshot 2025-12-02 at 11 06 48 AM"
src="https://github.com/user-attachments/assets/9624a71e-8b70-4e05-954d-41ddc79c73dd"
/>
@kevinkim-ogp
chore: add . for table label
93783e8
@kevinkim-ogp
v1.56.4
afbd7d6
@kevinkim-ogp kevinkim-ogp requested a review from a team as a code owner December 3, 2025 10:09
pregnantboy
pregnantboy approved these changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@pregnantboy pregnantboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lesgooo

@kevinkim-ogp kevinkim-ogp merged commit 2d40ccc into production Dec 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pregnantboy pregnantboy pregnantboy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevinkim-ogp @pregnantboy