Skip to content

Conversation

@m0nggh
Copy link
Contributor

@m0nggh m0nggh commented Oct 29, 2024

Details

  • Remove vault workspace references and make actions throw StepError

m0nggh and others added 2 commits October 29, 2024 13:48
## Details
- Right now, vault throws connection errors so we manually throw step
errors instead for the actions
Note: Keeping the previous `dynamicData` to be a `dropdown` type so that
the DB data is still preserved and user cannot change by configuring the
options.

Will setup a monitor to track pipes with such errors and notify them to
use Tiles or M365-excel instead.

## Tests
- [x] Vault actions throw error
@m0nggh m0nggh requested a review from a team as a code owner October 29, 2024 05:52
@datadog-opengovsg
Copy link

Datadog Report

Branch report: develop-v2
Commit report: 13681fb
Test service: plumber

✅ 0 Failed, 687 Passed, 0 Skipped, 1m 54.19s Total Time
➡️ Test Sessions change in coverage: 1 no change

@m0nggh m0nggh merged commit 1122a16 into production Oct 29, 2024
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants