Release v1.29.7 #791
Merged
Release v1.29.7 #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem Plumber looks zoomed in on GSIB ## Solution By using the method in the previous PR. We simulate a zoom out by setting the font-size to a smaller value than 16 (i.e. 14). This works seemingly well since we use `rem` as much as possible.
…rt (#787) ## Changes 1. show error message when file is too large / invalid file type 2. change default dropzone background color <img width="899" alt="image" src="https://github.com/user-attachments/assets/aef903b6-934f-4932-8988-e4825840d7f0">
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Datadog ReportBranch report: ✅ 0 Failed, 687 Passed, 0 Skipped, 2m 0.06s Total Time |
m0nggh
approved these changes
Nov 8, 2024
Contributor
m0nggh
left a comment
m0nggh
left a comment
There was a problem hiding this comment.
ok tested that it works on gsib: the difference in font size, lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes