Skip to content

Conversation

@m0nggh
Copy link
Contributor

@m0nggh m0nggh commented Nov 19, 2024

Problem

Realised that we have conflicting formats dd/LL/yy vs yy/LL/dd and it could pose as a problem when people use this format later in a delay step

Solution

Remove the yy/LL/dd datetime format

Regression test

  • Check that prod doesn't have any steps that uses this date format thankfully (only 2 but both are deleted)
    Simple query:
SELECT
	*
FROM
	steps
WHERE
	key = 'dateTime'
	and parameters::text ilike '%"formatDateTimeToFormat": "yy/LL/dd"%''

@m0nggh m0nggh requested a review from a team as a code owner November 19, 2024 04:01
@datadog-opengovsg
Copy link

Datadog Report

Branch report: chore/formatter/remove-date-option
Commit report: 6777eee
Test service: plumber

✅ 0 Failed, 687 Passed, 0 Skipped, 2m 4.5s Total Time
🔻 Test Sessions change in coverage: 1 decreased (-0.02%)

🔻 Code Coverage Decreases vs Default Branch (1)

@pregnantboy pregnantboy merged commit 9bc1bf4 into develop-v2 Nov 27, 2024
3 checks passed
@pregnantboy pregnantboy deleted the chore/formatter/remove-date-option branch November 27, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants