Release v1.40.2 #967
Merged
Release v1.40.2 #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kevinkim-ogp
commented
May 5, 2025
kevinkim-ogp
commented
- Add learning resources to sidebar
- Improve missing pipe page
- Prevent duplicate form submissions
## TL;DR Update missing Pipe page to be similar to missing Tile page ## How to test? - [ ] Navigate to a non-existent Pipe, verify that missing Pipe page is shown and clicking on link redirects to Pipes page ## Screenshots ### Before <img width="1512" alt="Screenshot 2025-04-28 at 11 17 33 PM" src="https://github.com/user-attachments/assets/ec2400d5-62a8-4785-a86f-11b701b97c2a" /> ### After https://github.com/user-attachments/assets/c1387d13-1e52-4f62-9a77-8baec29bd78b
## Details - Added an external link to the learning resources because right now, there is no way to access it from our plumber app. - Made it responsive for mobile and smaller screens too - Moved the new badge from `Templates` to `Learn` button instead ## Before & After Screenshots **BEFORE**: https://github.com/user-attachments/assets/fd0467d3-8cb3-4192-81a0-83e66dcf1c53 **AFTER**: https://github.com/user-attachments/assets/9df27e15-4ed8-42b9-be48-0f526301e525 ## Tests - Check that all pages can still be accessed e.g. pipes, tiles - Check that learning resource page is accessed as a new tab
## Problem FormSG may call Plumber's webhook more than once, which results in duplicate executions. ## Solution * Saves the FormSG Submission ID in the `internal_id` column * Every FormSG call to Plumber's webhook will check for the submission ID, if an execution has executed with the submission ID, it will not execute again * Use an advisory lock to prevent race conditions when FormSG concurrently triggers Plumber’s webhook with the same submission ID ## Tests - [ ] Existing Pipes with FormSG work as intended - [ ] New Pipes with FormSG work as intended - [ ] Call Plumber webhook with a prior form submission and ensure that Pipe does not execute again ## Deploy Notes * Run migration to add new index to `Executions` table: `flow_id`, `test_run`, `internal_id`
Datadog ReportBranch report: ✅ 0 Failed, 772 Passed, 0 Skipped, 2m 25.7s Total Time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.