[RFC] feat: convert to monorepo, move starter kit into apps/web, add tooling packages #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
karrui
changed the title
karrui
changed the title
karrui
changed the title
Collaborator
Author
|
Closing; probably leave it to users themselves to convert their repo to a monorepo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[RFC]
I am experimenting with moving Starter Kit to a monorepo; the thought process was that IaC can live in the same repository as the app code, and might as well move to monorepo to reap other monorepo benefits.
However, our IaC should realistically be kept private; so might not make sense for all all projects (especially the open-sourced ones). still, I’ve seen the DX improvements (shared config, proper dependency graphs) in my time in ActiveSG, DGS, and Isomer and might be good to have monorepos as a default moving forward.
still thinking about it, maybe if I make a CLI then users can choose between the two options. But prefer to have a singular option so maintenance is not a PITA.
What changed?
turborepo, and move the app toapps/web.How to test?
npm installto install the new dependencies and set up the workspaces.Why make this change?
To streamline the development process by providing a consistent tsconfig, linting and formatting experience across the codebase. This will help in maintaining code quality and reducing the overhead of manually configuring these tools for each package.