Skip to content

Conversation

@karrui
Copy link
Collaborator

@karrui karrui commented Mar 25, 2025

This pull request introduces several important changes aimed at improving the testing infrastructure by integrating IntegreSQL for database management and updating dependencies. The most significant changes are the addition of services to the CI workflow, updates to docker-compose.test.yml, modifications to package.json, and enhancements to test setup and configuration files.

CI and Docker Configuration:

  • .github/workflows/ci.yml: Added PostgreSQL and IntegreSQL services to the CI workflow to ensure consistent database environments during testing.
  • docker-compose.test.yml: Introduced a new Docker Compose file to define services for PostgreSQL and IntegreSQL, including performance tuning for local development.

Package Updates:

  • package.json: Added new scripts for test setup, replaced @electric-sql/pglite with @devoxa/integresql-client, and updated several dependencies including @vitest/coverage-istanbul and vitest. [1] [2] [3] [4]

Test Enhancements:

Integration with IntegreSQL:

Vitest Configuration:

  • vitest.config.ts: Updated to include global setup and mock files for Prisma integration.
  • vitest.global-setup.ts: Added a global setup script to initialize the template database with migrations before running tests.
  • vitest.setup.ts: Removed old setup logic for PGlite and Prisma, replaced by new IntegreSQL setup.

@vercel
Copy link

vercel bot commented Mar 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starter-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 9:21am

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Mar 25, 2025

Datadog Report

Branch report: ci/integresql
Commit report: e581297
Test service: starter-kit

✅ 0 Failed, 12 Passed, 0 Skipped, 16.76s Total Time
⬆️ Test Sessions change in coverage: 1 increased (+0.5%)

@karrui
Copy link
Collaborator Author

karrui commented Mar 25, 2025

oh i'll try to do this for e2e tests too

edit: decided against this, since we do want it to be true e2e

we should avoid constructing the shell command as a single string and instead use execFileSync to pass the command and its arguments separately. This approach ensures that the shell does not misinterpret any special characters in the paths or arguments.
@karrui karrui merged commit d058784 into main Mar 25, 2025
15 checks passed
@karrui karrui deleted the ci/integresql branch March 25, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant