[Worxlandroid] Initial contribution

[clinique]

This binding is used since a while as a standalone - let's get it merged.

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/worx-landroid-binding/95246/570

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/worx-landroid-binding/95246/609

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/worx-landroid-binding/95246/619

[lsiepel]

Thanks for contributing this binding. This is a partly review, i only looked at the documentation, thing structure and some metadata files. I'll continue my review when i find some more time.
I noticed an images folder, i guess that can be removed as they do not seem to be used anywhere.

[clinique]

@lsiepel : do you think it would be possible to give this one another chance targetting v5.2 ?

[lsiepel]

@lsiepel : do you think it would be possible to give this one another chance targetting v5.2 ?

Yes, I think so. I have a long weekend without work and this was pr was already on the top of my todo list. Similar to the other mqtt/aws pr

[lsiepel]

Some more comments i noticed when reading all PR details again.
In the mean whil i look at the AWS part.

[lsiepel]

Build error:

[INFO] org.openhab.binding.worxlandroid/README.md:38 error MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
[INFO] org.openhab.binding.worxlandroid/README.md:197 error MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]

[clinique]

Build error:

[INFO] org.openhab.binding.worxlandroid/README.md:38 error MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
[INFO] org.openhab.binding.worxlandroid/README.md:197 error MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]

Corrected.

[lsiepel]

I finally had some time to look into the osgifying the SDK. I tried it before, but at the time i thought the mechanism worked different.
This is corrected in: openhab/openhab-osgiify#116
When that PR is merged and the suggested changes here are done, i expect this to work as intended.

[clinique]

@lsiepel : pom and feature files modified upon your directions.

[lsiepel]

Just pushed a small commit to sort the dependency troubles. It should all be sorted now. @clinique could you verify all works as expected?

I reviewed the binding. LGTM

Would be nice if @jlaur can review the dependency changes i made and/or trust @clinique test's, so we can merge this.

You could add the addon's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui

[clinique]

@lsiepel : unfortunately this does not seem to work at the moment. I updated demo.app, cleaned project, mvn clean install. Same thing for worxlandroid binding, pulling your last update. When I try to resolve dependencies, I get:

Resolution failed. Capabilities satisfying the following requirements could not be found:
    [<<INITIAL>>]
      ⇒ osgi.identity: (osgi.identity=org.openhab.binding.worxlandroid)
          ⇒ [org.openhab.binding.worxlandroid version=5.2.0.202604130831]
              ⇒ osgi.wiring.package: (osgi.wiring.package=software.amazon.awssdk.crt)

[clinique]

In the meantime, I'm sure we'll succeed, I created the PR for the logo

[lsiepel]

When the jar is dropped in the addon folder, you also need to provide the dependency's that are not bundled in the jar itself. You can download the aws-crt dependency file here:
https://1drv.ms/u/c/70ea7ac46bc61c73/IQCG8KkDQICiTopiSvcTwzxtAbkDcj1XWXjRfiuSuBn1OkU?e=NyMCFg

Shipped bindings will do this automatically by karaf/felix. While troubleshooting i discovered something was wrong with the osiified library. I'll create a PR right away to fix that, it is already included in the linked file above.
Please continue your test with this file.

[clinique]

When the jar is dropped in the addon folder, you also need to provide the dependency's that are not bundled in the jar itself. You can download the aws-crt dependency file here: https://1drv.ms/u/c/70ea7ac46bc61c73/IQCG8KkDQICiTopiSvcTwzxtAbkDcj1XWXjRfiuSuBn1OkU?e=NyMCFg

Shipped bindings will do this automatically by karaf/felix. While troubleshooting i discovered something was wrong with the osiified library. I'll create a PR right away to fix that, it is already included in the linked file above. Please continue your test with this file.

I did put your provided jar along with the binding jar in /usr/share/openhab/addons and it works:

Good job @lsiepel

[lsiepel]

The comment #16893 (review) has been burried a little bit, so just for @jlaur a repost. Feel free to merge whenever you are ready.

[jlaur]

The comment #16893 (review) has been burried a little bit, so just for @jlaur a repost. Feel free to merge whenever you are ready.

Sorry for the slow response, read it on my phone and forgot it a few times, since I needed to look at this proper from a computer. 🙂 If you mean ebdd5ec, then that LGTM. 👍

[lsiepel]

Yes, that was what i meant. In the meanwhile the osgified dependency had an optimization that marked the graalvm dependency optional, so i'll remove it here and merge the PR as is.
Give me a day