Skip to content

[knx] Code rework#17420

Merged
lsiepel merged 2 commits into
openhab:mainfrom
holgerfriedrich:pr-rework
Sep 15, 2024
Merged

[knx] Code rework#17420
lsiepel merged 2 commits into
openhab:mainfrom
holgerfriedrich:pr-rework

Conversation

@holgerfriedrich

@holgerfriedrich holgerfriedrich commented Sep 15, 2024

Copy link
Copy Markdown
Member

Cleanup the code, fix typos, remove unnecessary files.
Simplify switch statements using Java17 language features.

No functional changes intended.

@holgerfriedrich holgerfriedrich added the work in progress A PR that is not yet ready to be merged label Sep 15, 2024
@holgerfriedrich holgerfriedrich marked this pull request as draft September 15, 2024 16:51
@holgerfriedrich holgerfriedrich force-pushed the pr-rework branch 2 times, most recently from 7cc1249 to 2ad5329 Compare September 15, 2024 20:00
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich removed the work in progress A PR that is not yet ready to be merged label Sep 15, 2024
@holgerfriedrich holgerfriedrich added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Sep 15, 2024
@holgerfriedrich holgerfriedrich marked this pull request as ready for review September 15, 2024 20:06

@lsiepel lsiepel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question to double check. Otherwise LGTM

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Sep 15, 2024
@lsiepel lsiepel merged commit 2d403dc into openhab:main Sep 15, 2024
@lsiepel lsiepel added this to the 4.3 milestone Sep 15, 2024
@holgerfriedrich holgerfriedrich deleted the pr-rework branch September 15, 2024 20:50
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Sep 24, 2024
* [knx] Code rework

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* [knx] Code rework

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* [knx] Code rework

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
* [knx] Code rework

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants