[shelly] Implement WebSocket keep alive for Gen2+ devices staying always connected#20268
Open
markus7017 wants to merge 25 commits intoopenhab:mainfrom
Open
[shelly] Implement WebSocket keep alive for Gen2+ devices staying always connected#20268markus7017 wants to merge 25 commits intoopenhab:mainfrom
markus7017 wants to merge 25 commits intoopenhab:mainfrom
Conversation
Note: The class isn't fully thread-safe because that would mean to make all (final) field implementations thread-safe as well. But, the class itself is. Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Note: The class isn't fully thread-safe because that would mean to make all (final) field implementations thread-safe as well. But, the class itself is. Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
…profile immutable. Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
…he ThingHandler Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
…s (since they can't be restarted) Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
…vlet Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
…ymore Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
devices Signed-off-by: Markus Michels <markus7017@gmail.com>
used) Signed-off-by: Markus Michels <markus7017@gmail.com>
alwaysOn devices. The PONG will restart the watchdog. WS connection idle time has been reduced to 5 min, which means about 4 retries if the devices does not respond once per minute. Signed-off-by: Markus Michels <markus7017@gmail.com>
markus7017
added
enhancement
Contributor
Author
|
@Nadahar I added the keep alive mechanism and verified that connection timeout is set to 300sec. I tried to get the remaining idle time, but Jetty just returns the configured timeout value, not the current value fyi: We can't use @OnWebSocketPong, because using Jetty 9.4.58, which is very old (current Jetty version is 12.x) |
Contributor
Ah, ok - but isn't there another way to register (not using annotations?). |
Contributor
Author
|
yes. there is another listener interface, but than requires for method to be implemented and somehow interfered with the annotations (maybe you could only use one or the other) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR implements
PR #20069 and 20248 need to be merged first.