Skip to content

[openuv] Document the UVMaxEvent trigger#20637

Merged
lsiepel merged 4 commits intoopenhab:mainfrom
jimtng:openuv-doc-trigger
Apr 27, 2026
Merged

[openuv] Document the UVMaxEvent trigger#20637
lsiepel merged 4 commits intoopenhab:mainfrom
jimtng:openuv-doc-trigger

Conversation

@jimtng
Copy link
Copy Markdown
Contributor

@jimtng jimtng commented Apr 27, 2026

No description provided.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng
Copy link
Copy Markdown
Contributor Author

jimtng commented Apr 27, 2026

@florian-h05, @HolgerHees I'd appreciate your review on the corresponding language example, thanks!

Specifically I'm not sure if JSScripting has a simpler syntax that would allow for any triggered event on the given channel like in the other languages.

@openhab-bot
Copy link
Copy Markdown
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/trigger-channels-and-a-thought-how-can-i-know-what-the-trigger-outputs/169153/5

@jimtng jimtng marked this pull request as ready for review April 27, 2026 02:28
@jimtng jimtng requested a review from clinique as a code owner April 27, 2026 02:28
@HolgerHees
Copy link
Copy Markdown
Contributor

for python... LGTM

Comment thread bundles/org.openhab.binding.openuv/README.md Outdated
Comment thread bundles/org.openhab.binding.openuv/README.md Outdated
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>

Co-authored-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: jimtng <2554958+jimtng@users.noreply.github.com>
@jimtng
Copy link
Copy Markdown
Contributor Author

jimtng commented Apr 27, 2026

@clinique, @florian-h05 and @HolgerHees thanks for the review.

FYI this page shows that the "event" is not optional, hence why I passed an empty string.
https://openhab.github.io/openhab-js/triggers.html

@florian-h05
Copy link
Copy Markdown
Contributor

FYI this page shows that the "event" is not optional, hence why I passed an empty string.

Fixed: openhab/openhab-js#524

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds end-user documentation for the OpenUV binding’s UVMaxEvent trigger so users can react to the day’s UV maximum in rules.

Changes:

  • Documented the UVMaxEvent trigger channel and when it fires.
  • Added multi-language rule examples (DSL / JavaScript / Python / JRuby) showing how to use the trigger.
  • Minor README formatting tweaks in nearby sections (tables / code fences).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bundles/org.openhab.binding.openuv/README.md Outdated
Comment thread bundles/org.openhab.binding.openuv/README.md Outdated
jimtng added 2 commits April 27, 2026 23:32
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Copy link
Copy Markdown
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 772576e into openhab:main Apr 27, 2026
2 checks passed
@lsiepel lsiepel added this to the 5.2 milestone Apr 27, 2026
@jimtng jimtng deleted the openuv-doc-trigger branch April 27, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants