[tapocontrol] 20710-KLAP Protocol PowerCycle Recovery for 1.4.6 firmware#21118
Open
dghenshaw wants to merge 2 commits into
Open
[tapocontrol] 20710-KLAP Protocol PowerCycle Recovery for 1.4.6 firmware#21118dghenshaw wants to merge 2 commits into
dghenshaw wants to merge 2 commits into
Conversation
Resend RSA discovery key to device if logon fails, e.g. after power-cycle of P110,P115 with firmware 1.4.6. Add port 20004 to discovery port list. Optimise discovery with parallel multi-port scanning Signed-off-by: David Henshaw <david@henshaws.me> Update TapoUdpDiscovery.java
Minor change to documentation. Signed-off-by: David Henshaw <david@henshaws.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix to resend RSA discovery key to device if logon permanently fails, e.g. after power-cycle of P110 or P115 with firmware 1.4.6.
(Note it is still necessary to disable & re-enable third-party compatibility in the Tapo-App following a firmware update or new device addition.)
Also: Add port 20004 to discovery port list.
Speed up discovery by using parallel discovery-port scanning rather than sequential scans.
Add tapo device's "tpap-preferred" status to its discoveryResult record.
Link to binding for testing: https://drive.google.com/file/d/1dPvA9KfQF0TzXfud4R5qlkzVHZcxy8DS/view?usp=sharing
Fixes #20710
Signed-off-by: David Henshaw david@henshaws.me