[dirigera] Bugfix device set capabilities#21119
Open
weymann wants to merge 6 commits into
Open
Conversation
weymann
force-pushed
the
bugfix/dirigera-deviceset-properties
branch
from
71ab8a7 to
2b91cfd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Dirigera binding bug where IKEA device sets (e.g., light sets) don’t expose capabilities at the set level, causing command handling (notably color temperature) to be rejected even though member devices support it (as described in issue #21053).
Changes:
- Aggregate capabilities for a light set by fetching properties from each member device during initialization.
- Refactor
BaseHandler.updateProperties()to delegate to a newupdateProperties(String id)overload. - Reformat the Dirigera binding
pom.xmlXML header/layout.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| bundles/org.openhab.binding.dirigera/src/main/java/org/openhab/binding/dirigera/internal/handler/light/LightSetHandler.java | Initializes set capabilities by iterating over member devices and applying their properties/capabilities. |
| bundles/org.openhab.binding.dirigera/src/main/java/org/openhab/binding/dirigera/internal/handler/BaseHandler.java | Introduces updateProperties(String id) to support fetching model properties for arbitrary device IDs. |
| bundles/org.openhab.binding.dirigera/pom.xml | Adjusts XML formatting of the POM header/opening tag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
weymann
force-pushed
the
bugfix/dirigera-deviceset-properties
branch
from
bcf793e to
8e5b59f
Compare
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IKEA device sets don't provide capabilities. They need to be fetched from each device which is part of the set,
Resolves #21053