[homeconnectdirect] Fix program progress reset - #21518
Merged
Merged
Conversation
The program progress reset was checking the channel ID instead of the device description key, so the lookup never matched and the branch was dead code. Related to openhab#21341 Signed-off-by: Jonas Brüstel <openhab@bruestel.net>
bruestel
force-pushed
the
homeconnectdirect-issue-21341
branch
from
August 28, 2026 09:05
bd5e943 to
a836a98
Compare
bruestel
marked this pull request as ready for review
August 28, 2026 09:05
Contributor
|
To be backported to branch 5.2.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix.
The branch that resets the
program-progresschannel to 0 % passed the channel ID (program-progress) toisOptionAvailableAndReadable(), which expects a device description key such asBSH.Common.Option.ProgramProgress. The lookup could therefore never match, the condition was alwaysfalseand the branch has effectively been dead code.The key is now taken straight from the change event, which the branch is already filtered on. The condition itself stays unnegated, because the two neighbouring branches are intentionally asymmetric:
Finishedsets it to 100 % there.This is an alternative to #21456, which added a negation instead; the rationale is discussed in #21341.
Note that this most likely does not change the behaviour reported in #21341: the
program-progresschannel is set to 100 % while the appliance is in theFinishedstate and back to 0 % once it leaves that state, which is handled by the operation state value handler. That part is still under investigation, so the issue should stay open.No user-visible configuration or documentation changes.
Related to #21341
Testing
Built with
mvn clean install -pl :org.openhab.binding.homeconnectdirect(build success, no new static analysis findings).