Skip to content

Semantic Tags: Update system channel tags to match latest schema #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kaikreuzer merged 6 commits into from
Apr 19, 2025
Merged

Semantic Tags: Update system channel tags to match latest schema #4706

kaikreuzer merged 6 commits into from
Apr 19, 2025
+47 −27

Conversation

@andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Apr 7, 2025 •
edited
Loading

Signed-off-by: Andrew Fiddian-Green [email protected]

@andrewfg
update tags to match xsd
5702e67 
Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg andrewfg requested a review from a team as a code owner April 7, 2025 12:32
@andrewfg
Copy link
Contributor Author

andrewfg commented Apr 7, 2025

@jimtng

@andrewfg
use tag name constants
c4850ac 
Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg
Copy link
Contributor Author

andrewfg commented Apr 7, 2025

@jimtng this opens a couple more issues => see my comments // TODO in the source code

@jimtng
Copy link
Contributor

jimtng commented Apr 7, 2025

@jimtng this opens a couple more issues => see my comments // TODO in the source code

+1

@andrewfg
oveload withTags()
e2e1da1 
Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg
Copy link
Contributor Author

andrewfg commented Apr 8, 2025

add overloads for ChannelTypeBuilder.withTag and ChannelTypeBuilder.withTags taking SemanticTag and Collection, respectively

@jlaur an excellent suggestion; thank you; in fact I overloaded just withTags() to take a varargs collection.

@andrewfg andrewfg mentioned this pull request Apr 8, 2025
Merged
@andrewfg
fix todo's
3e1d072 
Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg andrewfg mentioned this pull request Apr 9, 2025
Merged
@andrewfg andrewfg changed the title Update system channel tags to match xsd Semantic Tags: Update system channel tags to match xsd Apr 12, 2025
@andrewfg andrewfg changed the title Semantic Tags: Update system channel tags to match xsd Semantic Tags: Update system channel tags to match the latest schema Apr 14, 2025
@andrewfg andrewfg changed the title Semantic Tags: Update system channel tags to match the latest schema Semantic Tags: Update system channel tags to match latest schema Apr 17, 2025
kaikreuzer
kaikreuzer approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 87cab4e into openhab:main Apr 19, 2025
4 checks passed
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label Apr 19, 2025
@kaikreuzer kaikreuzer added this to the 5.0 milestone Apr 19, 2025
@andrewfg andrewfg deleted the system-channel-tags branch December 14, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

+2 more reviewers

@jimtng jimtng jimtng left review comments

@jlaur jlaur jlaur left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement An enhancement or new feature of the Core

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewfg @jimtng @kaikreuzer @jlaur