Regenerate rules from templates #4718
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 11, 2025 20:12
Signed-off-by: Ravi Nadahar <[email protected]>
Signed-off-by: Ravi Nadahar <[email protected]>
Signed-off-by: Ravi Nadahar <[email protected]>
Signed-off-by: Ravi Nadahar <[email protected]>
Nadahar
pushed a commit
to Nadahar/openhab-addons
that referenced
this pull request
May 21, 2025
Signed-off-by: Ravi Nadahar <[email protected]>
|
I've created openhab/openhab-addons#18705 which should be merged if this is merged. It handles the small change to |
|
I have created two "companion PRs" that should go together with this: The add-ons PR only modified one official add-on to accommodate the small change to The UI PR makes the functionality for which this PR lays the foundation actually available to users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerate rules from templates
Provide the ability to regenerate template based rules.
Description
Currently, template based rules must be deleted and recreated from the same template if the template is updated or if there is a need to change some of the configuration parameters (like linking the rule to a different Item). This PR provides the base functionality to enable regeneration of rules without having to delete and recreate them.
This PR alone won't do much, it will only enable the required functionality through the REST API. A companion PR will be posted for MainUI that will make use of the provided functionality.
This does contain a small change to the API in that
RuleRegistryimplementations must also implementregenerateFromTemplate, although if no template support is required for theRuleRegistryimplementation, the method can be blank. This PR will require an update to anyRuleRegistryimplementations that exist outside of Core.