Refactor to avoid possible null pointer dereference in YamlModelRepositoryImpl #4788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
reviewed
May 6, 2025
| return false; | ||
| } | ||
|
|
||
| List<JsonNode> removedNodes = e.getValue(); |
There was a problem hiding this comment.
Please check that removedNodes is not null before calling parseJsonNodesV1. parseJsonNodesV1 expects a non nullable list as parameter.
It generates an error in Eclipse if not for a good reason.
There was a problem hiding this comment.
I've added a null check here
…itoryImpl Signed-off-by: Jimmy Tanagra <[email protected]>
Signed-off-by: Jimmy Tanagra <[email protected]>
Signed-off-by: Jimmy Tanagra <[email protected]>
jimtng
force-pushed
the
yaml-null-warnings
branch
from
68fb6ad to
a459a79
Compare
|
rebased |
kaikreuzer
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Nadahar see f5f8921#r156317816
The compiler issued warnings about null type mismatch. There may be a small possibility that it would return null in case
modelCache/modelis modified elsewhere perhaps. This refactor removes that possibility and as a result the compiler no longer has a warning about it.