Skip to content

Conversation

@Artur-Fedjukevits
Copy link

As discussed in the ChatGPT PR this PR introduces a new bundle org.openhab.core.hli for Human Language Interpreters. It defines the new EnhancedHLIInterpreter interface, extending the existing HumanLanguageInterpreter with support for structured replies (ChatReply and Card).

Additionally, the following classes have been moved from HABot into this new bundle as plain model classes so they can be reused across add-ons:

  • Card
  • Component
  • Intent
  • CardProvider
  • CardRegistry

This allows add-ons like HABot and ChatGPT HLI to share the same core definitions without creating cross-dependencies.

Signed-off-by: Artur-Fedjukevits <[email protected]>
@Artur-Fedjukevits
Copy link
Author

I’ve compiled a test distro including the new org.openhab.core.hli bundle. You can use it to test the Core changes locally. Just add there compiled habot and chatgpt

@wborn wborn requested a review from Copilot September 10, 2025 07:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new bundle org.openhab.core.hli for Human Language Interpreters, establishing a shared foundation for structured chat replies and UI components across OpenHAB add-ons. The primary purpose is to avoid cross-dependencies between add-ons like HABot and ChatGPT HLI by providing common model classes.

  • Introduces the EnhancedHLIInterpreter interface extending HumanLanguageInterpreter with structured reply support
  • Moves core model classes (Card, Component, Intent, CardProvider, CardRegistry) from HABot to the new shared bundle
  • Adds ChatReply class for structured communication between HLI implementations and frontends

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
bundles/org.openhab.core.hli/pom.xml Maven configuration for the new HLI bundle
bundles/org.openhab.core.hli/src/main/java/org/openhab/core/hli/*.java Core HLI model classes and interfaces
bundles/pom.xml Adds HLI module to parent POM
features/karaf/openhab-core/src/main/feature/feature.xml Includes HLI bundle in core feature
bom/openhab-core/pom.xml Adds HLI dependency to BOM

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Artur-Fedjukevits and others added 6 commits September 10, 2025 22:27
…i/Card.java

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
…i/ChatReply.java

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
…i/Intent.java

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
…i/Card.java

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
…i/Card.java

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
@florian-h05
Copy link
Contributor

@openhab/core-maintainers Please let me review this before reviewing/merging yourself.

Signed-off-by: Artur-Fedjukevits <[email protected]>
@wborn wborn requested a review from florian-h05 September 11, 2025 17:13
@Artur-Fedjukevits
Copy link
Author

Hi @florian-h05. Have you had a chance to look at this PR?

@Artur-Fedjukevits
Copy link
Author

@wborn Is there someone else who could look at this PR?

@florian-h05
Copy link
Contributor

No, sorry.
I am currently very focused on the Vue 3 upgrade of Main UI …

@Artur-Fedjukevits
Copy link
Author

Hi all,
Just a gentle reminder about this PR — it’s been open for over two months. The scope is fairly small and should take about a couple of hours to review. I’d really appreciate if someone could take a look when they have a moment.
Thanks!

@Artur-Fedjukevits
Copy link
Author

@florian-h05 Have you had a chance to look at this PR?

@florian-h05
Copy link
Contributor

Not yet, sorry. The Vue 3 upgrade of Main UI and its aftermath is taking most of my openHAB time ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants