-
-
Notifications
You must be signed in to change notification settings - Fork 459
Add HLI bundle with EnhancedHLIInterpreter and shared Card/Component model #5016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Artur-Fedjukevits <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
bundles/org.openhab.core.hli/src/main/java/org/openhab/core/hli/Component.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new bundle org.openhab.core.hli for Human Language Interpreters, establishing a shared foundation for structured chat replies and UI components across OpenHAB add-ons. The primary purpose is to avoid cross-dependencies between add-ons like HABot and ChatGPT HLI by providing common model classes.
- Introduces the EnhancedHLIInterpreter interface extending HumanLanguageInterpreter with structured reply support
- Moves core model classes (Card, Component, Intent, CardProvider, CardRegistry) from HABot to the new shared bundle
- Adds ChatReply class for structured communication between HLI implementations and frontends
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| bundles/org.openhab.core.hli/pom.xml | Maven configuration for the new HLI bundle |
| bundles/org.openhab.core.hli/src/main/java/org/openhab/core/hli/*.java | Core HLI model classes and interfaces |
| bundles/pom.xml | Adds HLI module to parent POM |
| features/karaf/openhab-core/src/main/feature/feature.xml | Includes HLI bundle in core feature |
| bom/openhab-core/pom.xml | Adds HLI dependency to BOM |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bundles/org.openhab.core.hli/src/main/java/org/openhab/core/hli/Intent.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.hli/src/main/java/org/openhab/core/hli/Card.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.hli/src/main/java/org/openhab/core/hli/ChatReply.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.hli/src/main/java/org/openhab/core/hli/Card.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core.hli/src/main/java/org/openhab/core/hli/Card.java
Outdated
Show resolved
Hide resolved
…i/Card.java Co-authored-by: Copilot <[email protected]> Signed-off-by: Artur-Fedjukevits <[email protected]>
…i/ChatReply.java Co-authored-by: Copilot <[email protected]> Signed-off-by: Artur-Fedjukevits <[email protected]>
…i/Intent.java Co-authored-by: Copilot <[email protected]> Signed-off-by: Artur-Fedjukevits <[email protected]>
…i/Card.java Co-authored-by: Copilot <[email protected]> Signed-off-by: Artur-Fedjukevits <[email protected]>
…i/Card.java Co-authored-by: Copilot <[email protected]> Signed-off-by: Artur-Fedjukevits <[email protected]>
Signed-off-by: Artur-Fedjukevits <[email protected]>
|
@openhab/core-maintainers Please let me review this before reviewing/merging yourself. |
Signed-off-by: Artur-Fedjukevits <[email protected]>
|
Hi @florian-h05. Have you had a chance to look at this PR? |
|
@wborn Is there someone else who could look at this PR? |
|
No, sorry. |
|
Hi all, |
|
@florian-h05 Have you had a chance to look at this PR? |
|
Not yet, sorry. The Vue 3 upgrade of Main UI and its aftermath is taking most of my openHAB time ... |
As discussed in the ChatGPT PR this PR introduces a new bundle org.openhab.core.hli for Human Language Interpreters. It defines the new EnhancedHLIInterpreter interface, extending the existing HumanLanguageInterpreter with support for structured replies (ChatReply and Card).
Additionally, the following classes have been moved from HABot into this new bundle as plain model classes so they can be reused across add-ons:
This allows add-ons like HABot and ChatGPT HLI to share the same core definitions without creating cross-dependencies.