Fix default value #5239
Open
Fix default value #5239
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Siepel <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR fixes the default value of the hideDefaultParameters query parameter for the /create API endpoint introduced in version 5.1.0, changing it from false to true to align with other similar endpoints and address usability concerns raised in issue #5238.
Key Changes:
- Changed
@DefaultValue("false")to@DefaultValue("true")for thehideDefaultParametersparameter in the/createendpoint
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
There was not an agreement to change this default. @jimtng is even in favor to maintain the current default and to change the call in the API caller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #5238
This PR changes the default setting of the
hideDefaultParametersparameter for the newly (in 5.1.0) introduced file-format/create AP{I endpoint. Rationale in the linked issue.